Adding the log to the required action to show the cause of syntax violation of the LDAP policy #46245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation of the LDAP policy Closes keycloak#44459 Signed-off-by: Peter Skopek <[email protected]>
mposolda
reviewed
Feb 12, 2026
| throw ErrorResponse.error(e.getMessage(), Response.Status.INTERNAL_SERVER_ERROR); | ||
| } catch (ModelException e) { | ||
| logger.warn("Could not update user password.", e); | ||
| logger.warnf("Could not update password for user %s. Reason: %s", user.getUsername(), e.getCause().getMessage()); |
Contributor
There was a problem hiding this comment.
It seems that test failures are regression of this change.
I guess that e.getCause() is sometimes null? So perhaps might be rather something to check nulls. IMO it would be also good to still log original exception at least at the trace level as it is sometimes useful to see the whole trace for debugging/investigating the cause of some particular issue.
Suggested change
| logger.warnf("Could not update password for user %s. Reason: %s", user.getUsername(), e.getCause().getMessage()); | |
| String exceptionMessage = e.getCause() == null ? e.getMessage() : e.getCause().getMessage(); | |
| logger.warnf("Could not update password for user %s. Reason: %s", user.getUsername(), exceptionMessage); | |
| if (log.isTraceEnabled()) { | |
| log.tracef("Could not update user password.", e); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the log to the required action to show the cause of syntax violation of the LDAP policy
Closes #44459