Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Adding the log to the required action to show the cause of syntax violation of the LDAP policy #46245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pskopek wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Adding the log to the required action to show the cause of syntax violation of the LDAP policy #46245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/services/resources/admin/UserResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ public void resetPassword(@Parameter(description = "The representation must cont
logger.error(e.getMessage(), e);
throw ErrorResponse.error(e.getMessage(), Response.Status.INTERNAL_SERVER_ERROR);
} catch (ModelException e) {
logger.warn("Could not update user password.", e);
logger.warnf("Could not update password for user %s. Reason: %s", user.getUsername(), e.getCause().getMessage());
Copy link
Contributor

@mposolda mposolda Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that test failures are regression of this change.

I guess that e.getCause() is sometimes null? So perhaps might be rather something to check nulls. IMO it would be also good to still log original exception at least at the trace level as it is sometimes useful to see the whole trace for debugging/investigating the cause of some particular issue.

Suggested change
logger.warnf("Could not update password for user %s. Reason: %s", user.getUsername(), e.getCause().getMessage());
String exceptionMessage = e.getCause() == null ? e.getMessage() : e.getCause().getMessage();
logger.warnf("Could not update password for user %s. Reason: %s", user.getUsername(), exceptionMessage);
if (log.isTraceEnabled()) {
log.tracef("Could not update user password.", e);
}

Properties messages = AdminRoot.getMessages(session, realm, auth.adminAuth().getToken().getLocale());
throw new ErrorResponseException(e.getMessage(), MessageFormat.format(messages.getProperty(e.getMessage(), e.getMessage()), e.getParameters()),
Status.BAD_REQUEST);
Expand Down
Loading