Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Infrastructure: cache Qt installation for Windows#6048

Merged
vadi2 merged 3 commits intodevelopmentfrom
cache-qt-installation
Apr 11, 2022
Merged

Infrastructure: cache Qt installation for Windows#6048
vadi2 merged 3 commits intodevelopmentfrom
cache-qt-installation

Conversation

@vadi2
Copy link
Member

@vadi2 vadi2 commented Apr 8, 2022

Brief overview of PR changes/additions

Cache Qt installation for Windows

Motivation for adding to Mudlet

Keep our Windows builds fast

Other info (issues closed, discussion etc)

We didn't need to cache it previously since Qt was provided by Appveyor itself. Now that it's no longer the case (#6030), there's a need to manage caching ourselves.

@vadi2 vadi2 requested a review from a team April 8, 2022 09:17
@add-deployment-links
Copy link

add-deployment-links bot commented Apr 8, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Apr 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Messages
✔️

PR type: Infrastructure

Generated by 🚫 dangerJS against 1449aa2

@vadi2 vadi2 marked this pull request as draft April 8, 2022 11:04
@vadi2
Copy link
Member Author

vadi2 commented Apr 8, 2022

@vadi2 vadi2 marked this pull request as ready for review April 9, 2022 07:22
@vadi2
Copy link
Member Author

vadi2 commented Apr 9, 2022

This works well now. Saving cache:

image

Restoring cache:

image

@vadi2 vadi2 merged commit d06c917 into development Apr 11, 2022
@vadi2 vadi2 deleted the cache-qt-installation branch April 11, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants