Infrastructure: install Qt 5.14.2 using aqtinstaller for Windows#6030
Merged
vadi2 merged 4 commits intodevelopmentfrom Apr 7, 2022
Merged
Infrastructure: install Qt 5.14.2 using aqtinstaller for Windows#6030vadi2 merged 4 commits intodevelopmentfrom
vadi2 merged 4 commits intodevelopmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Member
Author
|
Strange error: Configure output: Going to re-run the build. |
Member
Author
|
Error is fixed, it's all good now. |
demonnic
approved these changes
Apr 6, 2022
SlySven
requested changes
Apr 6, 2022
Member
SlySven
left a comment
There was a problem hiding this comment.
Sorry to block this but you need to also remove ./CU/qt-silent-install.qs from the repository to avoid leaving it as cruft...
Member
Author
|
Sure, removed. |
This was referenced Apr 7, 2022
vadi2
pushed a commit
that referenced
this pull request
Apr 22, 2022
During running of the CI builds on AppVeyor for Windows we now are getting errors during the `.configure` stage for the build of PCRE - and we get the advices to try using the additional `--disable-dependency-tracking` to fix it. This PR tried to do that to see if it fixed things, but it didn't. Further investigation by @keneanung and myself eventually revealed that although #6030 installed Qt it was not installing the expected Mingw GCC compiler (32-bit 7.3.0) - further digging revealed that an addition step was needed to do that. During the investigation I spotted that when building `libzip` we were also building the regression tests, the documentation and the examples - none of which are used or needed by our Windows CI builds. So disabling them should reduce the build time slightly and there was no point to undoing the change that disabled their being built. Signed-off-by: Stephen Lyons <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
This might also fix it for the desktop, non-CI compilation people are doing - but that is not the intent of this PR just yet.