Infrastructure: repair Windows CI build failures#6072
Merged
vadi2 merged 10 commits intoMudlet:developmentfrom Apr 22, 2022
Merged
Infrastructure: repair Windows CI build failures#6072vadi2 merged 10 commits intoMudlet:developmentfrom
vadi2 merged 10 commits intoMudlet:developmentfrom
Conversation
During running of the CI builds on AppVeyor for Windows we now are getting errors during the `.configure` stage for the build of PCRE - and we get the advices to try using the additional `--disable-dependency-tracking` to fix it. This commit does that to see if it fixes things...! Signed-off-by: Stephen Lyons <[email protected]>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Compile libzip is now failing when building the unneeded documentation! Signed-off-by: Stephen Lyons <[email protected]>
…uild Sometimes we might want make to only do one thing at a time. Signed-off-by: Stephen Lyons <[email protected]>
Signed-off-by: Stephen Lyons <[email protected]>
Signed-off-by: Stephen Lyons <[email protected]>
… check Signed-off-by: Stephen Lyons <[email protected]>
I think this will fail to get us `qt.tools.win32_mingw730` as I think I've already tried to get that one - this though will show us all the ones we could get... Signed-off-by: Stephen Lyons <[email protected]>
Signed-off-by: Stephen Lyons <[email protected]>
Now that a solution seems to have been found it is time to clean up the PR. One unneed change can be left in place - is the elimination of some auxillary parts of libzip. Note that the failure to build in the previous commit was due to an addition that this commit is removing (trying to force make to only run a single job at a time). So this should be the required fix. Signed-off-by: Stephen Lyons <[email protected]>
Member
Author
|
The danger failure is a separate matter that needs addressing. It is apparently: error [email protected]: The engine "node" is incompatible with this module. Expected version ">=14.13.1". Got "12.22.12" |
The older version is no longer supported by the tool and as the test is a requirement it needs fixing ASAP. Signed-off-by: Stephen Lyons <[email protected]>
keneanung
approved these changes
Apr 22, 2022
Member
keneanung
left a comment
There was a problem hiding this comment.
The solution is surprisingly simple once we got to the root... I say go for it and merge even though danger is failing. We can't repair that with an all green PR due to the pull_request_target trigger.
Member
|
I disabled the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During running of the CI builds on AppVeyor for Windows we now are getting errors during the
.configurestage for the build of PCRE - and we get the advices to try using the additional--disable-dependency-trackingto fix it. This PR tried to do that to see if it fixed things, but it didn't.Further investigation by @keneanung and myself eventually revealed that although #6030 installed Qt it was not installing the expected Mingw GCC compiler (32-bit 7.3.0) - further digging revealed that an addition step was needed to do that.
During the investigation I spotted that when building
libzipwe were also building the regression tests, the documentation and the examples - none of which are used or needed by our Windows CI builds. So disabling them should reduce the build time slightly and there was no point to undoing the change that disabled their being built.Signed-off-by: Stephen Lyons [email protected]