Fix Artillery units not losing autohit mod after spending mp #6994
Conversation
5dd5b27 to
fe039ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6994 +/- ##
============================================
+ Coverage 30.32% 30.33% +0.01%
- Complexity 15855 15874 +19
============================================
Files 2890 2890
Lines 283352 283363 +11
Branches 49313 49316 +3
============================================
+ Hits 85927 85969 +42
+ Misses 191799 191768 -31
Partials 5626 5626 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (md.getMpUsed() > 0) { | ||
| // All auto-hit hexes for this unit (not including preset targets) are cleared | ||
| // if any MP are expended. | ||
| entity.aTracker.clearHitHexMods(); |
There was a problem hiding this comment.
I think a report would be reasonable for this. But not vital.
There was a problem hiding this comment.
Sorry, I had stepped away for dinner.
The only issue with reporting is that this is happening during the movement phase, as each move is executed, so reports inserted here would be interleaved with the normal movement reporting.
It feels a little wrong to insert reports about lost auto-hit artillery mods into the move report, but we could store the removed Coords in the ArtilleryTracker and report them during the next Indirect Phase report...
Actually, it might be good to report any auto-hit mods on a per-unit basis as well since we don't do that either.
I'll file an RFE, but I think it's outside the sope of this fix.
Fix for Artillery units moving but keeping their auto-hit mods on hexes they've already hit.
This patch adds a new method to the ArtilleryTracker to remove only those autohit mods when a unit expends MP.
Note that other mods (such as base artillery mod, spotter adjustment mod, etc.) should not be modified by this method, as only the auto-hit mod is lost after movement (per TO:AR rules).
Testing:
Close #6929