Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@SJuliez
Copy link
Member

@SJuliez SJuliez commented May 29, 2025

Fixes some malfunctioning calls get get a boardview when in the lobby (e.g. when calling the Generated Map dialog)

@SJuliez SJuliez requested a review from a team as a code owner May 29, 2025 17:30
@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 30.64%. Comparing base (a913775) to head (d527ef0).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...mek/src/megamek/client/ui/clientGUI/ClientGUI.java 0.00% 5 Missing ⚠️
...gamek/client/ui/clientGUI/boardview/BoardView.java 0.00% 2 Missing ⚠️
.../megamek/client/ui/dialogs/TurretFacingDialog.java 0.00% 2 Missing ⚠️
...lient/ui/panels/phaseDisplay/lobby/ChatLounge.java 0.00% 2 Missing ⚠️
...logs/forceDisplay/ForceDisplayMekTreeRenderer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7173   +/-   ##
=========================================
  Coverage     30.64%   30.64%           
- Complexity    17121    17131   +10     
=========================================
  Files          2968     2968           
  Lines        289614   289619    +5     
  Branches      50488    50488           
=========================================
+ Hits          88750    88766   +16     
+ Misses       194263   194254    -9     
+ Partials       6601     6599    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rjhancock rjhancock merged commit 0ac1e8e into MegaMek:master May 29, 2025
7 checks passed
@SJuliez SJuliez deleted the tilemanager-problems branch July 10, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants