Allow issues to use NAMESPACE/REPO identifier #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08ab1e3 to
85ecc37
Compare
Collaborator
|
Thanks for the contribution but I think this was already covered in #253! |
Contributor
|
@asedge we still need this one. |
Contributor
|
Cifrene = current |
Collaborator
|
OK, merged. Thanks! |
andrew
added a commit
to librariesio/gitlab
that referenced
this pull request
Apr 11, 2017
* upstream/master: release 4.0.0 Move .file_contents to RepositoryFiles module, matching GitlabHQ API doc. Also update route so it actually works with APIv4. Fix .get_file for new APIv4 route Update gitignore Add ability to get all issues a merge_request will close (NARKOZ#271) Update CHANGELOG, add some missing entries. Block/unblock user now uses POST instead of PUT. Fixes NARKOZ#262. Adds ability to create commits (NARKOZ#264) Rename "git hook" to "push rule". Closes NARKOZ#233. Change project fork endpoint for v4 API. Closes NARKOZ#236. Add v4-endpoint to fetch all merge_requests for a milestone (NARKOZ#265) Fixes NARKOZ#222, using deploy_keys endpoint (NARKOZ#261) (Un)subscribe to issues and merge_requests (NARKOZ#260) Update merge_request endpoints to new merge_requests endpoints (NARKOZ#256) Fix failing test that was called with a pre-urlencoded string. Allow issues to use NAMESPACE/REPO identifier (NARKOZ#255) Feature/230 note that project id can also be a string (NARKOZ#253)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can use
intbased ID to identify a project, or you can useNAMESPACE/REPOaccording to the API documentation: https://docs.gitlab.com/ce/api/projects.html#get-single-projectThe advantage of using
NAMESPACE/REPOeverywhere, is that you don't need to first load the repository to get the numeric ID so you can use it on other places.The gem itself already allows the use of the "literal" identification, but there is one check in the issues getter that prevents it's use. This PR fixes that.
cc @NARKOZ @connorshea @asedge