-
Notifications
You must be signed in to change notification settings - Fork 164
var obs converter quickbuild.sh fix #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added var converter executables to .gitignore
|
@mjs2369 Hi Marlee, when you get a chance can you review this pull request. For the review, looking for:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 21 of observations/obs_converters/var/3DVAR_OBSPROC/README should have the directory as WRF/var/obsproc/MAP_plot/include as oppsosed to WRFDA/var/obsproc/MAP_plot/include, which doesn't exist (i.e. there is no /var directory in the WRFDA repo). The converter was tested and successfully compiled with the files found in WRF/var/obsproc/MAP_plot/include.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a link to the WRF repo, as well as clarifying the directory the files need to be copied into, may eliminate some difficulties for our users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be two redundant links in DART/observations/obs_converters/var/var.rst
The links on lines 14 and 15, for :doc:./littler_tf_dart and :doc:./rad_3dvar_to_dart, lead to the current page (var.rst). Or in other words, the links don't take you anywhere.
|
Helen, in addition to the comments above, there is the issue we discussed in which var.rst can only be found on the documentation website when searching for it (https://dart-documentation--362.org.readthedocs.build/en/362/observations/obs_converters/var/var.html?highlight=var). It can not be found in the list of docs for converter programs or elsewhere in the menu. The changes made to the code allowed for a successful compile of the var converter using ./quickbuild. |
Co-authored-by: Marlena Smith <[email protected]>
Added which directory var.rst is referring to
done. |
Added var to the list of obs converters |
The links work correctly in readthedocs output: https://dart-documentation--362.org.readthedocs.build/en/362/observations/obs_converters/var/var.html but unfortunately the links do not work in GitHub. Possibly someone has solved this problem, but fixing this for the DART docs is out of scope for this We are not the only people to have this problem, here is VAPOR's docs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good and I believe it is ready to merge with main.
Description:
var observation converter was not being built by quickbuild.sh
Added the 3DVAR_OBSPROC directory to quickbuild.sh so the build completes successfully.
Fixes issue
Fixes #361
Types of changes
Documentation changes needed?
Fixed broken WRFDA link in README and added where to find the list of WRF files to var.rst
Tests
Compiled converter:
Tested the build with both of these.
Checklist for merging
Same release as #363
Testing Datasets