Fix for MITgcm_ocean pert_model_copies #363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Querying the variable id and clamping value for each state element.
In pert_model_copies the state vector is spread out round-robin across the processors, so the check for clamping value must be done for each element.
INDICES loop is now
INDICES : do i = 1, state_ens_handle%my_num_vars. Previously the INDICES loop wasINDICES : do i = start_ind, end_indwhich caused pert_model_copies to segfault.Removed module global random_seq since this is not used.
Fixes issue
fixes #360
Types of changes
Documentation changes needed?
Tests
Perturbed MIT ocean test case.
Checklist for merging
Testing Datasets
Here is a test case for filter log_transform=.false.
/glade/scratch/hkershaw/DART/MITgcm/test_small_domain.no-nans.no-log
And for log_transform=.true.
/glade/scratch/hkershaw/DART/MITgcm/test_small_domain.no-nans.log