Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hkershaw-brown
Copy link
Member

@hkershaw-brown hkershaw-brown commented Jun 21, 2022

Description:

  • Querying the variable id and clamping value for each state element.
    In pert_model_copies the state vector is spread out round-robin across the processors, so the check for clamping value must be done for each element.

  • INDICES loop is now INDICES : do i = 1, state_ens_handle%my_num_vars. Previously the INDICES loop was
    INDICES : do i = start_ind, end_ind which caused pert_model_copies to segfault.

  • Removed module global random_seq since this is not used.

Fixes issue

fixes #360

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Perturbed MIT ocean test case.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Version tag

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

Here is a test case for filter log_transform=.false.
/glade/scratch/hkershaw/DART/MITgcm/test_small_domain.no-nans.no-log

And for log_transform=.true.
/glade/scratch/hkershaw/DART/MITgcm/test_small_domain.no-nans.log

Copy link
Contributor

@mgharamti mgharamti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks Helen.

Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and successfully passed the pert_model_copies routine with debugging flags. Ready to merge with main.

@hkershaw-brown hkershaw-brown merged commit 9c7d829 into main Jun 24, 2022
@hkershaw-brown hkershaw-brown deleted the mitgcm-perturb branch June 24, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: MITgcm pert_model_copies

4 participants