Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hkershaw-brown
Copy link
Member

@hkershaw-brown hkershaw-brown commented Jan 10, 2022

Description:

The nvidia compiler enforces the fortran standard that characters in namelists must have "" or ''. This pull request removes the
"string or integer namelist" option added in pull request #154. It does not remove any of the integer parameters added to to adaptive_inflate_mod in #154

The standard is:
Note 10.33, in 10.9.1.3

"A character sequence corresponding to a namelist input item of character data type shall be delimited either with apostrophes or quotes. The delimiter is required to avoid ambiguity between undelimited character sequences and object names. The value of the DELIM = specifier, if any, in the OPEN statement for an external file is ignored during namelist input "

(Note 10.36 in the f2008 standard).

Fixes issue

Fixes #245

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    Using strings in the namelist to specify inflation flavor was added to main but not documented. Anyone who is using strings will need to revert to using integers instead, e.g.
  &filter_mod
-  inf_flavor                  = VARYING_SS_INFLATION,                       NO_INFLATION ,
+  inf_flavor                  = 2,                       0,
/
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

  • Lorenz_96 compile and run with nvfortran (nvhpc module on Cheyenne)
  • Bitwise test with intel on main.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Version tag

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed. You can use lorenz_96

@hkershaw-brown hkershaw-brown changed the title bug-fix for #245 namelist values need to be the same type as variable bug-fix for #245 character namelist values need to be the same type as variable Jan 10, 2022
@hkershaw-brown hkershaw-brown changed the title bug-fix for #245 character namelist values need to be the same type as variable bug-fix character namelist values need to be the same type as variable Jan 10, 2022
Copy link
Collaborator

@nancycollins nancycollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks good.

i think eventually all inflation related namelist items merit their own namelist in the adaptive_inflate_mod module. at that point we can use string names properly delimited with quotes to specify the various types of inflation.

@jlaucar
Copy link
Contributor

jlaucar commented Jan 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pgi does not like the inflation flavors being integers.

4 participants