bug-fix character namelist values need to be the same type as variable #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The nvidia compiler enforces the fortran standard that characters in namelists must have "" or ''. This pull request removes the
"string or integer namelist" option added in pull request #154. It does not remove any of the integer parameters added to to adaptive_inflate_mod in #154
The standard is:
Note 10.33, in 10.9.1.3
"A character sequence corresponding to a namelist input item of character data type shall be delimited either with apostrophes or quotes. The delimiter is required to avoid ambiguity between undelimited character sequences and object names. The value of the DELIM = specifier, if any, in the OPEN statement for an external file is ignored during namelist input "
(Note 10.36 in the f2008 standard).
Fixes issue
Fixes #245
Types of changes
Using strings in the namelist to specify inflation flavor was added to main but not documented. Anyone who is using strings will need to revert to using integers instead, e.g.
Documentation changes needed?
Tests
Checklist for merging
Testing Datasets