🌎 A few more basic stencils#337
Merged
FlorianDeconinck merged 3 commits intoNOAA-GFDL:developfrom Dec 9, 2025
Merged
Conversation
Add set_value on 2D bool masks
oelbert
approved these changes
Dec 9, 2025
Collaborator
oelbert
left a comment
There was a problem hiding this comment.
Minor preference on naming, but otherwise happy for this to go in
ndsl/stencils/basic_operations.py
Outdated
Comment on lines
50
to
62
| def set_value_2D_defn(buffer: FloatFieldIJ, value: Float) -> None: | ||
| """ | ||
| Sets every element of buffer to the value specified by value argument. | ||
|
|
||
| Args: | ||
| buffer: output field | ||
| value: value of Float type | ||
| """ | ||
| with computation(FORWARD), interval(0, 1): | ||
| buffer = value | ||
|
|
||
|
|
||
| def set_IJ_mask_value_defn(mask_out: BoolFieldIJ, value: Bool) -> None: |
Collaborator
There was a problem hiding this comment.
I don't love the _defn part of the stencil names, would rather have set_value_2d and set_ij_mask_value but that's a minor nit
Collaborator
Author
There was a problem hiding this comment.
Agreed - I will remove it in the current ones and make a duplication/deprecation for the older ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding basic stencils to help with transparent orchestration without the advanced
Quantityoperations:ndsl.stencilslevel importHow has this been tested?
Trivial repeat of previous stencils.
Checklist