refactor: deprecate duplicate basic stencil definitions#358
Merged
romanc merged 1 commit intoNOAA-GFDL:developfrom Jan 9, 2026
Merged
Conversation
Some basic stencils were named with a `_defn` suffix. We don't think the suffix is necessary and thus deprecate the version with a suffix and schedule their removal for the next release. The deprecation warning can't be in the stencil itself. The python frontend of gt4py won't like this. I will thus warn from the stencil factory (which is assumed to be used in one way or another). Lastly, the PR updates `test_basic_operations.py` to use the boilerplate module and avoid much of the setup by using `get_factories_single_tile`.
Collaborator
|
Poke @oelbert / @CharlesKrop / @katrinafandrich for reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some basic stencils were named with a
_defnsuffix. We don't think the suffix is necessary and thus deprecate the version with a suffix and schedule their removal for the next release.The deprecation warning can't be in the stencil itself. The python frontend of gt4py won't like this. I will thus warn from the stencil factory (which is assumed to be used in one way or another).
Lastly, the PR updates
test_basic_operations.pyto use the boilerplate module and avoid much of the setup by usingget_factories_single_tile.This is a follow-up from PR #337.
How has this been tested?
New & adapted test cases.
Checklist