fastly: 3.1.0 -> 3.1.1 #180540
Merged
fastly: 3.1.0 -> 3.1.1 #180540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
approved these changes
Jul 7, 2022
ereslibre
suggested changes
Jul 7, 2022
Member
ereslibre
left a comment
There was a problem hiding this comment.
Given fastly/cli#588 has been merged and included in this release I think we can get advantage of that instead of setting the go version -- which still works, but I think we can improve that --.
cc/ @06kellyjac @bdd @shyim
Member
|
I will review this later on and approve if the binary is fine. We can do the changes related to fastly/cli#588 on a follow-up PR. |
Member
|
yep it should continue to set version info fine since I made the PR backwards compatible. Changing it in a future PR sounds fine |
ereslibre
approved these changes
Jul 8, 2022
Member
ereslibre
left a comment
There was a problem hiding this comment.
LGTM, the binary works as expected and reports the version correctly:
❯ result/bin/fastly version
Fastly CLI version v3.1.1 (59efd38)
Built with go version go1.17.11 darwin/amd64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/fastly/versions.
meta.description for fastly is: "Command line tool for interacting with the Fastly API"
meta.homepage for fastly is: "https://github.com/fastly/cli"
meta.changelog for fastly is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
passthru.tests, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-reviewrun on x86_64-linux 11 package built:
Maintainer pings
cc @ereslibre @shyim @kalbasit for testing.