Handle build info more accurately #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Integralist
requested changes
Jun 29, 2022
Collaborator
Integralist
left a comment
There was a problem hiding this comment.
Thanks, @06kellyjac for opening this PR, this is very welcomed.
I have a few comments if you could address them, please.
8bf5dfc to
e4ba9ce
Compare
06kellyjac
commented
Jun 29, 2022
`runtime.Version()` will always give an accurate build host version For the host's GOOS and host's GOARCH they're not available so they must still be passed in via ldflags The Makefile has been modified to use goreleaser for the fastly item
Integralist
approved these changes
Jun 29, 2022
Collaborator
Integralist
left a comment
There was a problem hiding this comment.
Thanks again, this is a great clean-up effort.
Contributor
Author
|
No problem. It'd be nice if runtime or buildinfo also exposed the host os and arch and we wouldn't need any of these env vars (the info is there but only within an internal library :/) but this will do for now |
Contributor
Author
|
I just realized I didn't touch the Dockerfiles but it looks like they grab the release so that doesn't need touching I do need to fix the snapshot tests though by the looks of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime.Version()will always give an accurate build host versionhttps://cs.opensource.google/go/go/+/refs/tags/go1.18.3:src/runtime/extern.go;l=251-266
For the host's GOOS and host's GOARCH they're not available so they must still be passed in via ldflags
matches the
go versioncli outputhttps://github.com/golang/go/blob/master/src/cmd/go/internal/version/version.go#L76
make fastlynow uses goreleaser. I removed the cleanup comment and left the ldflags for the "dev" buildsMaybe the whole LDFLAGS entry can be removed and the dev builds just dont have version info?