10.0 mig web widget digitized signature #438

archetipo · 2016-10-11T08:44:28Z

No description provided.

…CA/sale-workflow#252 Rename module this module in web_widget_digitized_signature

…ature_user

eLBati · 2016-10-11T09:17:27Z

web_widget_digitized_signature/__manifest__.py

+    "name": "Web Widget Digitized Signature",
+    "version": "10.0.1.0.0",
+    "author": "Serpent Consulting Services Pvt. Ltd., "
+               "Agile Business Group"


Missing , at the end of this line

@eLBati thanks! done.

tafaRU · 2016-10-12T15:22:04Z

web_widget_digitized_signature/views/we_digital_sign_view.xml

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<odoo>
+    <data>


You can remove data tag

@tafaRU Thanks done.

[FIX] xml view file name

pedrobaeza · 2016-10-20T12:34:35Z

@eLBati, are you going to handle finally the switch to LGPL?

eLBati · 2016-10-20T16:29:55Z

@pedrobaeza, we stay AGPL.
@JayVora-SerpentCS prefers to keep it

jaronemo · 2016-11-07T14:31:05Z

Dears:

this module ...on v10 it's ok...
but...have problem...

signature --->save
re-open clear ----> failed

and can't support mobile device(ex: android table use chrome apps)

levkar · 2016-11-08T20:23:52Z

Have you seen my pull request for 8.0?

7 Kas 2016 16:31 tarihinde "Jason" [email protected] yazdı:

Dears:

this module ...on v10 it's ok...
but...have problem...

signature --->save

re-open clear ----> failed

and can't support mobile device(ex: android table use chrome apps)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#438 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AIMjqueZPlEkwekwyCh_eXq2qm-iT-Oxks5q7zYtgaJpZM4KTYvZ
.

archetipo · 2016-11-09T08:02:06Z

@jaronemo , @levkar thanks,
In step 2 , if you allow change signature after save, signature would not be reliable.
for mobile , i've not had time to testing the improvements of #394.

yajo · 2016-11-16T10:00:52Z

web_widget_digitized_signature/static/src/css/digital.css

@@ -0,0 +1,3 @@
+.openerp .oe_form_readonly .oe_edit_only, .openerp .oe_form_readonly .oe_form_field:empty {
+  display: none !important;


Avoid !important, use other CSS hierarchy rules to get to that please.

yajo · 2016-11-16T10:02:09Z

web_widget_digitized_signature/static/src/css/jquery.signature.css

@@ -0,0 +1,5 @@
+/* Styles for signature plugin v1.1.0. */


Shouldn't this go into lib folder? 😕

yajo · 2016-11-16T10:05:21Z

web_widget_digitized_signature/static/src/js/digital_sign.js

+                }
+            });
+
+            $('.save_sign').click(function(){


You mostly want to use this.$ or this.$el.find instead of plain $ to avoid these things affecting elements outside its element. Same happens in other places.

Also big methods bound to these elements would be much better if put as methods for this class, instead of scoped lambdas, to allow proper inheritance.

eLBati · 2017-09-11T15:17:38Z

I did the porting again, starting from 9.0 version: #725
This can be closed

pedrobaeza · 2017-09-11T15:19:24Z

Closing in favor of #725

archetipo and others added 9 commits October 11, 2016 10:27

web_widget_digital_signature_sale_order was moved in sale workflow O…

e5aed89

…CA/sale-workflow#252 Rename module this module in web_widget_digitized_signature

[FIX] module name in digital_sign.js

a4bbbd1

rename web_widget_digital_signature_user to web_widget_digitized_sign…

d328e0a

…ature_user

using FieldBinaryImage-signature name

85e772b

OCA Transbot updated translations from Transifex

df60237

OCA Transbot updated translations from Transifex

470ccfe

OCA Transbot updated translations from Transifex

e749493

OCA Transbot updated translations from Transifex

49f689a

[FIX] remove en.po that was erroneously created by transbot

a3fd084

pedrobaeza mentioned this pull request Oct 11, 2016

Migration to version 10.0 #435

Closed

59 tasks

eLBati suggested changes Oct 11, 2016

View reviewed changes

archetipo force-pushed the 10.0-mig-web_widget_digitized_signature branch from 1563ac4 to 6ffee3e Compare October 11, 2016 13:34

[MIG 10.0] web_widget_digitized_signature

045d7f8

archetipo force-pushed the 10.0-mig-web_widget_digitized_signature branch from 6ffee3e to 045d7f8 Compare October 11, 2016 13:35

tafaRU reviewed Oct 12, 2016

View reviewed changes

[FIX] remarks

0d9a2c8

[FIX] xml view file name

lasley added this to the 10.0 milestone Oct 15, 2016

lasley added the needs review label Oct 15, 2016

pedrobaeza mentioned this pull request Oct 20, 2016

[10] web_widget_digitized_signature #414

Closed

yajo requested changes Nov 16, 2016

View reviewed changes

pedrobaeza closed this Sep 11, 2017

		@@ -0,0 +1,3 @@
		.openerp .oe_form_readonly .oe_edit_only, .openerp .oe_form_readonly .oe_form_field:empty {
		display: none !important;

Uh oh!

10.0 mig web widget digitized signature #438

10.0 mig web widget digitized signature #438

Uh oh!

Conversation

archetipo commented Oct 11, 2016

Uh oh!

eLBati Oct 11, 2016

Choose a reason for hiding this comment

Uh oh!

archetipo Oct 11, 2016

Choose a reason for hiding this comment

Uh oh!

tafaRU Oct 12, 2016

Choose a reason for hiding this comment

Uh oh!

archetipo Oct 13, 2016

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Oct 20, 2016

Uh oh!

eLBati commented Oct 20, 2016

Uh oh!

jaronemo commented Nov 7, 2016

Uh oh!

levkar commented Nov 8, 2016

Uh oh!

archetipo commented Nov 9, 2016

Uh oh!

yajo Nov 16, 2016

Choose a reason for hiding this comment

Uh oh!

yajo Nov 16, 2016

Choose a reason for hiding this comment

Uh oh!

yajo Nov 16, 2016

Choose a reason for hiding this comment

Uh oh!

eLBati commented Sep 11, 2017

Uh oh!

pedrobaeza commented Sep 11, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants