Update js signature library to JSignature #394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JayVora-SerpentCS @archetipo what do you think about this? |
|
Sounds right, how about you @Meet_scs |
|
@eLBati @JayVora-SerpentCS looks good. 👍 |
ghost
reviewed
Nov 11, 2016
| this.$el.find('.save_sign').click(this.on_save_sign); | ||
| }, | ||
| on_clear_sign: function() { | ||
| if (this.get('value') !== false) { |
There was a problem hiding this comment.
I suggest you to directly check for the value.
if(this.get('value') && !_.isUndefined(value)){
// your code here.
}
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates js signature library to JSignature since it works with mobile as well.
This is the same update original author made in their own repo. Here's the related commit:
JayVora-SerpentCS/SerpentCS_Contributions@2d6c094
This can be considered as a sync.