[19.0][MIG] web_dialog_size: Migration to 19.0 #3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New module that let the user expand a dialog box to the full screen width.
* [IMP] web_dialog_size: Put dialog size expanded by default * [REM] web_popup_large: By duplication of the functionality * [IMP] web_dialog_size: README and contributors * [ADD] configuration parameter for default behavior [FIX] return super's promise [IMP] use fontawesome icons for buttons
…efault_maximize parameter
* IMP: Added draggable support to dialogs * FIX: web_dialog_size: export modal - PR OCA#733 introduced draggable dialogs which broke some of them
- default_maximize option wasn't working due to strict value comparison
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
Checking result of rpc call, `dialog_maximize`, will end to be always `true` as the method will return a json: `{'dialog_maximize': false }`. So i changed the test to test the value of json key `dialog_maximize`
Includes some manual fixes to silent ESLint warnings.
It is important to let users decide their default dialog size. Some have ultrawide monitors and this module does more harm than benefit. Here I add such task to roadmap, to avoid forgetting about it. @Tecnativa
[IMP] web_dialog_size: Migration to 16.0 [REM] Remove duplicate configuration readme file [FIX] Make it work for normal dialogs also [FIX] SelectCreateDialog precommit
Currently translated at 100.0% (1 of 1 strings) Translation: web-16.0/web-16.0-web_dialog_size Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_dialog_size/it/
The problems found on Legacy Dialogs are the next: 1. The modal can't be dragged 2. The button for extending and reduce the modal is doing nothing 3. The x for close the modal is showed twice You can test it with dialogs showed on Vault module
6b84c05 to
0e6299f
Compare
|
ping @pedrobaeza @CarlosRoca13 @DavidJForgeFlow for the reviews. Thanks in advance. |
|
/ocabot migration web_dialog_size |
pedrobaeza
approved these changes
Oct 15, 2025
giarve
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
Great job!! The last improvement this module could have is basically caching the get_web_dialog_size_config result in user local storage similar to web_remember_tree_column_width
Sometimes there is a delay for resizing (different issue than this one), but it is due to the http request being done every single time. Only shown in latency scenarios where the odoo server is located far away not localhost.
|
This PR has the |
|
@BhaveshHeliconia can you consider adding that enhancement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
27 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.