-
-
Couldn't load subscription status.
- Fork 660
[FIX][14.0] parsing fixed amount for discount #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @eLBati, |
|
For some reason pre-commit fails across this repo (not only this branch) with something like this: Anyone has any idea? @legalsylvain maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try rebasing, I think it's already fixed
|
/ocabot rebase |
The original line is obviously 1:1 copy from percentual discount which aimed to get value between 0 and 100 (percent) but in case of fixed discount doesn't make any sense and actually caps any input at 100.
|
Congratulations, PR rebased to 14.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
This PR has the |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at cf533e3. Thanks a lot for contributing to OCA. ❤️ |
The original line is obviously 1:1 copy from percentual discount which aimed to get value between 0 and 100 (percent) but in case of fixed discount doesn't make any sense and actually caps any input at 100.