Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Rad0van
Copy link

@Rad0van Rad0van commented Nov 23, 2022

The original line is obviously 1:1 copy from percentual discount which aimed to get value between 0 and 100 (percent) but in case of fixed discount doesn't make any sense and actually caps any input at 100.

@OCA-git-bot
Copy link
Contributor

Hi @eLBati,
some modules you are maintaining are being modified, check this out!

@Rad0van
Copy link
Author

Rad0van commented Nov 23, 2022

For some reason pre-commit fails across this repo (not only this branch) with something like this:

[INFO] Initializing environment for https://gitlab.com/PyCQA/flake8.
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags')
return code: 128
expected return code: 0
stdout: (none)
stderr:
    fatal: could not read Username for 'https://gitlab.com/': No such device or address

Anyone has any idea? @legalsylvain maybe?

@Rad0van Rad0van mentioned this pull request Nov 25, 2022
27 tasks
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try rebasing, I think it's already fixed

@ivantodorovich
Copy link

/ocabot rebase

The original line is obviously 1:1 copy from percentual discount which aimed to get value between 0 and 100 (percent) but in case of fixed discount doesn't make any sense and actually caps any input at 100.
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@ivs-cetmix
Copy link
Member

Module is fine. However would be great to add a configuration part.
Eg "Enable global discounts in POS settings"
image

@Rad0van
Copy link
Author

Rad0van commented Jan 20, 2023

Module is fine. However would be great to add a configuration part. Eg "Enable global discounts in POS settings" image

Well I was only trying to fix it really quickly. I guess such change would call for separate PR.

@ivs-cetmix
Copy link
Member

Module is fine. However would be great to add a configuration part. Eg "Enable global discounts in POS settings" image

Well I was only trying to fix it really quickly. I guess such change would call for separate PR.

Yup I agree with you. Just not to forget about this. Because It took me some extra time to figure this out during testing.

Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivantodorovich
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-888-by-ivantodorovich-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 27, 2023
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cf533e3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants