-
-
Notifications
You must be signed in to change notification settings - Fork 660
[15.0] [MIG] pos_fixed_discount #1051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently translated at 100.0% (5 of 5 strings) Translation: pos-12.0/pos-12.0-pos_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_fixed_discount/es/
The original line is obviously 1:1 copy from percentual discount which aimed to get value between 0 and 100 (percent) but in case of fixed discount doesn't make any sense and actually caps any input at 100.
|
/ocabot migration pos_fixed_discount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1051-by-ivantodorovich-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
The merge error should be fixed by /ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at a7186a1. Thanks a lot for contributing to OCA. ❤️ |
This is a replacement for closed #891 with cherry-picked #888