[15.0] [FIX] pos_sale_pos_event_sale: keep the event sale description after import
#1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…import This fixes a regression introduced by the following upstream changes: - odoo/odoo@51776fc - odoo/odoo@dbd766f - odoo/odoo@5a0113a The Orderline's name was being set to the product description, loosing the event and event ticket information that was previously being displayed. This caused our CI to fail, as the test was expecting the event sale description in there. The fix is to clear the ``full_product_name`` property for imported event lines, such that the displayed name is recomputed from the event and event ticket.
pos_sale_pos_event_sale: keep the event sale description after import
|
I'm fast-tracking this in order to unblock PRs to the 15.0 branch, as they're all failing because of this /ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at a9e0d2a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by the following upstream changes:
The Orderline's name was being set to the product description, loosing the event and event ticket information that was previously being displayed.
This caused our CI to fail, as the test was expecting the event sale description in there.
The fix is to clear the
full_product_nameproperty for imported event lines, such that the displayed name is recomputed from the event and event ticket.