load model from a json file #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa510ca to
4b68a63
Compare
4b68a63 to
3bb1a8d
Compare
izar
reviewed
Sep 16, 2020
Collaborator
izar
left a comment
There was a problem hiding this comment.
Can you take a look at the conflicts? I am not sure if you renamed or added to the _Bag* variables.
edc386c to
6c4d82f
Compare
6c4d82f to
dc8ed3b
Compare
Collaborator
Author
|
I rebased both this and #102 which is based on this branch and should be merged first, it'll make this diff a lot smaller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since #102 adds json output, this PR adds json input, for example if models can be created by exporting data from other systems