Add unique Finding ID instead of re-using Threat ID #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
reviewed
Apr 6, 2021
nineinchnick
approved these changes
Apr 6, 2021
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
izar
approved these changes
Apr 6, 2021
nozmore
pushed a commit
that referenced
this pull request
Apr 13, 2021
nozmore
pushed a commit
that referenced
this pull request
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when parsing JSON the Elements contain a list of findings which references only the Threat Id. Since a Threat and given ID can be assigned via a Finding to different components it is not possible to reference a specific finding.
This adds an incremental id to finding starting a 1. which can be used to retrieve the referenced finding.