Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Fix encoding errors due to compatibility between #151 and #154#157

Merged
izar merged 2 commits intomasterfrom
fix_encoding_error
Apr 13, 2021
Merged

Fix encoding errors due to compatibility between #151 and #154#157
izar merged 2 commits intomasterfrom
fix_encoding_error

Conversation

@nozmore
Copy link
Collaborator

@nozmore nozmore commented Apr 13, 2021

With #154 the Finding.id value is not an int and Threat.id is a str, the common encoding method needs to handle id differently between the 2 object types.

@nozmore nozmore requested a review from izar as a code owner April 13, 2021 15:42
@ghost
Copy link

ghost commented Apr 13, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

Copy link
Collaborator

@izar izar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works.

@izar izar merged commit 179467e into master Apr 13, 2021
@izar izar deleted the fix_encoding_error branch April 13, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants