Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix: Map Overlapping Side Navbar. #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonnieBLT merged 3 commits into from
Mar 20, 2025
Merged

Fix: Map Overlapping Side Navbar. #4021

DonnieBLT merged 3 commits into from
Mar 20, 2025

Conversation

@rinkitadhana
Copy link
Contributor

@rinkitadhana rinkitadhana commented Mar 20, 2025 •
edited by coderabbitai bot
Loading

Fixes #4013

Changes Introduced by this PR:

  • Increased z index of side navbar and header.

Changes:
image

Summary by CodeRabbit

  • New Features

    • Added an organization registration link to the sidebar for easier access.

  • Style

    • Redesigned the tools section layout with updated grid columns, improved hover animations, and refined text sizes for enhanced clarity and usability.

  • Chores

    • Adjusted the layering of navigation and sidebar elements to ensure they display prominently.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2025 •
edited
Loading

Walkthrough

The pull request updates several HTML templates to improve the visual presentation and stacking order of page elements. In the home template, the "Tools for Organizations" section has been restructured with adjusted grid columns, added descriptive content, and refined hover effects. In the header template, the navigation bar’s z-index has been increased to ensure it overlays other elements. The sidenav template also sees its z-index raised and includes a new submenu link for organization registration. No changes were made to exported or public entities.

Changes

File(s) Change Summary
website/templates/home.html Adjusted "Tools for Organizations" grid: changed primary grid from 6 to 5 columns, added a secondary grid with 5 columns, inserted descriptive <p> elements into tool links, updated hover transitions, and modified text size/margin classes.
website/templates/includes/header.html Increased the <nav> element z-index from 50 to 9999 to ensure it appears above other page elements.
website/templates/includes/sidenav.html Updated sidebar z-index from z-40 to z-[8888] and added a new submenu link for organization registration with a Font Awesome icon and active state styling.

Assessment against linked issues

Objective Addressed Explanation
Ensure navbar stacks above map (#4013) ✅

Suggested reviewers

  • DonnieBLT
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3610fc0 and 32a1462.

📒 Files selected for processing (3)
  • website/templates/home.html (1 hunks)
  • website/templates/includes/header.html (1 hunks)
  • website/templates/includes/sidenav.html (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Run Tests
  • GitHub Check: docker-test
🔇 Additional comments (5)
website/templates/includes/header.html (1)

10-10: Updated z-index on Navigation Bar.
The <nav> element’s z-index has been increased to z-[9999], which effectively ensures that the header appears above any overlapping elements on the page. This change aligns well with the PR’s objective of resolving stacking issues.

website/templates/includes/sidenav.html (2)

7-7: Sidebar z-index Enhancement.
The sidebar’s z-index is now set to z-[8888], which should help position it above conflicting elements and prevent unwanted overlapping. This improvement is consistent with the changes made in the header.

26-32: Addition of "Register Organization" Link.
A new submenu link has been added for organization registration. The link uses conditional class styling (based on request.path) to highlight its active state and includes a clear Font Awesome icon (fas fa-plus) along with descriptive text. This addition enhances the navigation by allowing users to quickly access the organization registration feature.

website/templates/home.html (2)

833-907: Enhanced Tools Grid Layout and Card Design.
The “Tools for Organizations” section has been updated with a refined grid layout that uses a 5‑column configuration on large screens. Additionally, the tool cards now feature consistent hover effects (e.g., hover:-translate-y-1), updated spacing (with descriptions using mt-1), and clear descriptive texts that improve both visual appeal and usability. This ensures that the organization-related tools are both prominent and easy to understand.

915-1106: Overall Home Page UI Integration.
The remaining sections of the home page—including feature highlights, project cards, referral program, leaderboard, and call-to-action segments—are well integrated with the updated navigation and sidebar layering. The consistent design language (shadows, transition effects, typography, and color usage) throughout the page contributes to a unified and enhanced user experience.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DonnieBLT DonnieBLT merged commit 034aca9 into OWASP-BLT:main Mar 20, 2025
10 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 20, 2025
Merged
@rinkitadhana rinkitadhana deleted the fix/map branch March 20, 2025 21:38
This was referenced Mar 20, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Map is overlapping navbar

2 participants

@rinkitadhana @DonnieBLT