-
-
Notifications
You must be signed in to change notification settings - Fork 313
Added Register Organization to Mega Menu Header #4048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the navigation elements by introducing a new link in the header that routes to the organization registration page and adjusting the sidebar text. Specifically, a new list item with an icon and a link to the registration view is added in the header, and the sidebar label is updated for clarity. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant B as Browser
participant S as Server
U->>B: Clicks "Register Organization" link in header
B->>S: GET /register_organization
S-->>B: Returns registration page HTML
B-->>U: Displays registration page
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
website/templates/includes/header.html (2)
8-9: Font Awesome Version Consistency
The header template loads Font Awesome v5.15.4, while elsewhere (e.g. in the sidenav) v6.4.0 is used. For a consistent icon appearance across the application, consider aligning them to the same version.
55-58: Consider Active State Styling
While the sidenav link for "Register Organization" includes conditional styling based on the current URL, the header mega menu item does not. You might consider adding similar active state logic to provide visual feedback when the organization registration page is active.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
website/templates/includes/header.html(1 hunks)website/templates/includes/sidenav.html(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Run Tests
- GitHub Check: docker-test
- GitHub Check: Analyze (python)
🔇 Additional comments (2)
website/templates/includes/sidenav.html (1)
26-31: Improved Navigation Label Clarity
The updated submenu item now reads "Register Organization" (changed from "Registers Organization"), which improves consistency and clarity with the header link.website/templates/includes/header.html (1)
55-58: New "Register Organization" Link Added
The new list item under the Organizations section correctly adds a link to the organization registration view with an appropriate plus icon. The implementation is clear and fits well into the mega menu structure.
Co-authored-by: DonnieBLT <[email protected]>
* mentor changes * chore(deps): Bump aiohttp from 3.11.14 to 3.11.15 Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.11.14 to 3.11.15. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.11.14...v3.11.15) --- updated-dependencies: - dependency-name: aiohttp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): Bump openai from 1.69.0 to 1.70.0 Bumps [openai](https://github.com/openai/openai-python) from 1.69.0 to 1.70.0. - [Release notes](https://github.com/openai/openai-python/releases) - [Changelog](https://github.com/openai/openai-python/blob/main/CHANGELOG.md) - [Commits](openai/openai-python@v1.69.0...v1.70.0) --- updated-dependencies: - dependency-name: openai dependency-version: 1.70.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): Bump sentry-sdk from 2.24.1 to 2.25.0 Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 2.24.1 to 2.25.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@2.24.1...2.25.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-version: 2.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * reminder-settings logic done * UI done for remdiner-settings * debug statement removed * chore(deps): Bump django from 5.1.7 to 5.1.8 Bumps [django](https://github.com/django/django) from 5.1.7 to 5.1.8. - [Commits](django/django@5.1.7...5.1.8) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): Bump aiohttp from 3.11.15 to 3.11.16 --- updated-dependencies: - dependency-name: aiohttp dependency-version: 3.11.16 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): Bump django-storages from 1.14.5 to 1.14.6 Bumps [django-storages](https://github.com/jschneier/django-storages) from 1.14.5 to 1.14.6. - [Changelog](https://github.com/jschneier/django-storages/blob/master/CHANGELOG.rst) - [Commits](jschneier/django-storages@1.14.5...1.14.6) --- updated-dependencies: - dependency-name: django-storages dependency-version: 1.14.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): Bump sentry-sdk from 2.25.0 to 2.25.1 Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 2.25.0 to 2.25.1. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@2.25.0...2.25.1) --- updated-dependencies: - dependency-name: sentry-sdk dependency-version: 2.25.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Shifted Kudos view to the api (#4083) * shifted to api * pre commit changes * pre-commit migration' * made rabbit changes * Verifying kudos sender through github login. (#4089) * shifted to api * pre commit changes * pre-commit migration' * made rabbit changes * verifying sender by github profile * pre commit fix * fixes ssrf in OWASP compliance check (#4091) * fixes ssrf in OWASP compliance check * isort * try block * Implemented change provided by coderabbitai -Voidoid (#4098) * Implemented change provided by coderabbitai -Voidoid * Update website/templates/hackathons/detail.html --------- Co-authored-by: Voidoid1977 <[email protected]> Co-authored-by: DonnieBLT <[email protected]> * done (#4101) * Fix: Fixed the queue page. (#4075) * side navbar fixed * launched_at added and conditions added for it * transaction fixed * paid field added * view queue feature added * pre-commit error * improved UI/UX of whole page * changes in the UI * removed discord and slack options * post on launch added * pre-commit error * pre-commit error fixed * added h and w to all img tags * coderabit changes * Delete_Page UI Fixed (#4100) * done * done * chat-bot fixed (#4052) Co-authored-by: DonnieBLT <[email protected]> * added a close button to delete the message chat in messages (#4032) * added a close button to delete the message chat in messages * removed all console logs --------- Co-authored-by: DonnieBLT <[email protected]> * Added Threat Intelligence section to the Organization dashboard (#4036) * added Threat Intelligence * fix * fix * fix --------- Co-authored-by: DonnieBLT <[email protected]> * done (#4048) Co-authored-by: DonnieBLT <[email protected]> * number updated for django migrations * deleted old file * extra line added * extra line added * code fix * pre-commit check * pre-commit run * pre-commit run * migration fix * optimized logic to send mails * migration * precommit * pre-commit run * pre-commit * pre-commit run * cron changes * migration fixes * migration fix * removed extra urls: code clean * import correction * using get_or_create now * code refactor and bug fix --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Krrish Sehgal <[email protected]> Co-authored-by: Abhishek Kumar <[email protected]> Co-authored-by: Voidoid1977 <[email protected]> Co-authored-by: Voidoid1977 <[email protected]> Co-authored-by: DonnieBLT <[email protected]> Co-authored-by: Lucky negi <[email protected]> Co-authored-by: Rinkit Adhana <[email protected]> Co-authored-by: Swaparup Mukherjee <[email protected]> Co-authored-by: sath000007 <[email protected]>
Fixes : #4062

Summary by CodeRabbit
Summary by CodeRabbit
New Features
Style
These enhancements improve the overall navigation experience and ensure a more coherent interface for organization registration.