Skip throttle checks during tests #4429

Copilot · 2025-07-10T05:39:47Z

This PR resolves the issue where the throttling middleware was interfering with tests by rate-limiting requests during test execution. Tests often need to make many requests quickly, which would trigger the throttling mechanism and cause test failures.

Changes Made

1. Modified `blt/middleware/throttling.py`

Added sys import to detect test mode
Added early return in should_skip_throttle() method when "test" in sys.argv
Added debug logging to track when throttling is skipped for tests

2. Updated `website/test_throttling_middleware.py`

Modified existing test to verify throttling is properly skipped during tests
Added new test case test_throttling_skipped_during_tests() to explicitly validate the skip behavior

Technical Details

The solution uses Django's standard approach for detecting test mode by checking sys.argv, which is consistent with how other parts of the codebase detect test execution. When tests are running, the middleware logs "Skipping throttling for test mode" and bypasses all throttling logic.

Benefits

Minimal Impact: Only 4 lines of code added
Non-Breaking: Production throttling behavior unchanged
Reliable: Tests can now make unlimited requests without being throttled
Well-Tested: Added comprehensive test coverage

Verification

# Tests pass with throttling skipped
$ python manage.py test website.test_throttling_middleware
# All 5 tests pass, debug logs show "Skipping throttling for test mode"

# Production behavior unchanged (throttling still works)
$ python /tmp/test_throttling_behavior.py
# Shows normal throttling with request counters incrementing

The debug logs clearly demonstrate the behavior:

During tests: DEBUG Skipping throttling for test mode
In production: DEBUG Throttle check for GET /path from IP: 127.0.0.1 - Current: 1/100

Fixes #4428.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

example.com
- Triggering command: /home/REDACTED/.cache/pypoetry/virtualenvs/blt-yuw0N2NF-py3.12/bin/python manage.py test website.test_api --verbosity=1 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: DonnieBLT <[email protected]>

coderabbitai · 2025-07-10T05:51:22Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

blt/middleware/throttling.py

website/test_throttling_middleware.py

Co-authored-by: DonnieBLT <[email protected]>

Copilot · 2025-07-10T07:08:28Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

install.python-poetry.org
- Triggering command: curl -sSL REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

Initial plan

162b853

Copilot AI assigned Copilot and DonnieBLT Jul 10, 2025

Copilot started work on behalf of DonnieBLT July 10, 2025 05:39 View session

Skip throttling middleware during tests

bc05223

Co-authored-by: DonnieBLT <[email protected]>

DonnieBLT approved these changes Jul 10, 2025

View reviewed changes

DonnieBLT marked this pull request as ready for review July 10, 2025 05:51

DonnieBLT enabled auto-merge July 10, 2025 05:51

DonnieBLT disabled auto-merge July 10, 2025 05:51

Copilot AI changed the title ~~[WIP] Skip Throttle check for tests~~ Skip throttle checks during tests Jul 10, 2025

Copilot AI requested a review from DonnieBLT July 10, 2025 05:52

Copilot finished work on behalf of DonnieBLT July 10, 2025 05:52