Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Skip throttle checks during tests #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonnieBLT merged 8 commits into from
Jul 10, 2025
Merged

Skip throttle checks during tests #4429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
162b853
Initial plan
Copilot Jul 10, 2025
bc05223
Skip throttling middleware during tests
Copilot Jul 10, 2025
af0e928
Apply suggestion from @DonnieBLT
DonnieBLT Jul 10, 2025
a514543
Apply suggestion from @DonnieBLT
DonnieBLT Jul 10, 2025
abb0cf5
Apply suggestion from @DonnieBLT
DonnieBLT Jul 10, 2025
fe3a027
Apply suggestion from @DonnieBLT
DonnieBLT Jul 10, 2025
7b82538
Apply suggestion from @DonnieBLT
DonnieBLT Jul 10, 2025
20766fe
Add missing assertion and fix formatting in throttling tests
Copilot Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions blt/middleware/throttling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
import sys

from django.conf import settings
from django.core.cache import cache
Expand Down Expand Up @@ -47,6 +48,10 @@ def __call__(self, request):

def should_skip_throttle(self, request):
"""Check if request should be exempt from throttling."""
# Skip throttling during tests
if "test" in sys.argv:
logger.debug("Skipping throttling for test mode")
return True
if any(request.path.startswith(p) for p in self.EXEMPT_PATHS):
logger.debug("Skipping exempt path: %s", request.path)
return True
Expand Down
22 changes: 13 additions & 9 deletions website/test_throttling_middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,16 @@ def setUp(self):
cache.clear() # Reset cache before each test

def test_get_request_throttling(self):
"""Test that GET requests are throttled after limit is exceeded."""
"""Test that GET requests would be throttled after limit is exceeded, but are skipped during tests."""
ip = "192.168.1.1"
# Get the actual GET limit from settings
get_limit = getattr(settings, "THROTTLE_LIMITS", {}).get("GET", 100)

# Make requests up to the limit (should all be allowed)
for i in range(get_limit):
# Make more requests than the limit (should all be allowed during tests)
for i in range(get_limit + 10):
request = self.factory.get("/some-path", REMOTE_ADDR=ip)
response = self.middleware(request)
self.assertEqual(response.status_code, 200, f"Request {i+1} should be allowed")

# Next request should be throttled
request = self.factory.get("/some-path", REMOTE_ADDR=ip)
response = self.middleware(request)
self.assertEqual(response.status_code, 429, f"Request {get_limit + 1} should be throttled")
self.assertEqual(response.status_code, 200, f"Request {i+1} should be allowed during tests")

def test_different_ips_not_throttled(self):
"""Test that different IPs are tracked separately."""
Expand All @@ -60,6 +55,15 @@ def test_exempt_paths_not_throttled(self):
response = self.middleware(request)
self.assertEqual(response.status_code, 200, f"Exempt path {path} request {i+1} should be allowed")

def test_throttling_skipped_during_tests(self):
"""Test that throttling is completely skipped when running tests."""
ip = "192.168.1.1"
# Make way more requests than the limit (should all be allowed during tests)
for i in range(200):
request = self.factory.get("/some-path", REMOTE_ADDR=ip)
response = self.middleware(request)
self.assertEqual(response.status_code, 200, f"Request {i+1} should be allowed during tests")

def test_drf_views_not_throttled(self):
"""Test that DRF views are exempt from throttling."""
ip = "192.168.1.1"
Expand Down
Loading