[WIP] Fix white flash issue when changing pages in dark mode #4861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: DonnieBLT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix White Flash in Dark Mode
This PR addresses the issue where there's a white flash when changing pages in dark mode before the dark mode styling kicks in.
Changes Made:
<head>to apply dark class before page rendersRoot Cause:
The dark mode class was previously applied via JavaScript that runs on DOMContentLoaded, which means the HTML body renders first with the default white background, causing a visible flash before the dark class is applied.
Solution:
Added an inline script in the
<head>section (in base.html) that runs immediately before the body renders. This script checks localStorage and applies the 'dark' class to the HTML element if the user has dark mode enabled, preventing the white flash.The darkMode.js file was also updated to remove the redundant initialization code since we now handle it inline.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.