Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Fix white flash issue when changing pages in dark mode #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonnieBLT merged 2 commits into from
Nov 16, 2025
Merged

[WIP] Fix white flash issue when changing pages in dark mode #4861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c9fbb1
Initial plan
Copilot Nov 16, 2025
bbc73a0
Fix white flash in dark mode by applying theme before page render
Copilot Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions website/static/js/darkMode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
document.addEventListener("DOMContentLoaded", () => {
const htmlElement = document.documentElement;

// Initialize theme from localStorage on page load
const savedTheme = localStorage.getItem("theme");
if (savedTheme === "dark") {
htmlElement.classList.add("dark");
}

// Use event delegation to handle clicks on the theme toggle button
document.addEventListener("click", (event) => {
Expand Down
9 changes: 9 additions & 0 deletions website/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,15 @@
darkMode: 'class',
}
</script>
<!-- Apply dark mode immediately to prevent white flash -->
<script>
(function() {
const savedTheme = localStorage.getItem("theme");
if (savedTheme === "dark") {
document.documentElement.classList.add("dark");
}
})();
</script>
<script src="{% static 'js/darkMode.js' %}" defer></script>
<!-- Add Moment.js and DateRangePicker dependencies -->
<script src="https://cdn.jsdelivr.net/momentjs/latest/moment.min.js"></script>
Expand Down