Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Anselmoo/issue540 #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 22, 2023
Merged

Anselmoo/issue540 #559

merged 5 commits into from
Jan 22, 2023

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jan 21, 2023 •
edited
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 21, 2023 •
edited
Loading

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.81 ⭐ 1.81 ⭐ 0.00
Method Length 56.12 ⭐ 56.12 ⭐ 0.00
Working memory 8.90 🙂 8.90 🙂 0.00
Quality 75.54% ⭐ 75.54% ⭐ 0.00%
Other metrics Before After Change
Lines 1048 1049 1
Changed files Quality Before Quality After Quality Change
spectrafit/__init__.py 100.00% ⭐ 100.00% ⭐ 0.00%
spectrafit/plugins/notebook.py 75.43% ⭐ 75.43% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/plugins/notebook.py __init__ 3 ⭐ 358 ⛔ 43 ⛔ 32.44% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/plugins/notebook.py solver_model 8 ⭐ 177 😞 14 😞 45.83% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/plugins/notebook.py DataFramePlot.plot_2dataframes 6 ⭐ 424 ⛔ 8 🙂 49.11% 😞 Try splitting into smaller methods
spectrafit/plugins/notebook.py DataFramePlot.plot_metric 0 ⭐ 195 😞 8 🙂 63.06% 🙂 Try splitting into smaller methods
spectrafit/plugins/notebook.py ExportReport.__init__ 0 ⭐ 90 🙂 11 😞 68.51% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance Maintenance & Security pre-commit python Pull requests that update Python code labels Jan 21, 2023
@codecov
Copy link

codecov bot commented Jan 21, 2023 •
edited
Loading

Codecov Report

Merging #559 (5443794) into main (0924de7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   99.55%   99.56%   +0.02%     
==========================================
  Files          34       37       +3     
  Lines        3046     3157     +111     
==========================================
+ Hits         3032     3143     +111     
  Misses         14       14
Impacted Files Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/api/rixs_model.py 100.00% <100.00%> (ø)
spectrafit/api/test/test_rixs_model.py 100.00% <100.00%> (ø)
spectrafit/plugins/notebook.py 99.70% <100.00%> (+0.01%) ⬆️
spectrafit/plugins/test/test_rixs_visualizer.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 22, 2023
@Anselmoo
test: ⚡ Startpwriting test for RIXS map
5443794 
test: ⚡ Coverage and Testing of API Model

test: 🚧 Start writing test for RIXS map

build: 📦 Update `.lock`

fix: 🔥 rename RIXS_model.py to rixs_model.py

docs: 🚧 Start docs via Jupyter
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anselmoo Anselmoo marked this pull request as ready for review January 22, 2023 20:28
@Anselmoo Anselmoo merged commit 37d53b0 into main Jan 22, 2023
@Anselmoo Anselmoo deleted the Anselmoo/issue540 branch January 22, 2023 20:28
@Anselmoo Anselmoo mentioned this pull request Jan 23, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation maintenance Maintenance & Security pre-commit python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Working with RIXS planes

1 participant

@Anselmoo