Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: 🚨 Pylint Fix #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

fix: 🚨 Pylint Fix #564

merged 1 commit into from
Jan 23, 2023

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jan 23, 2023 •
edited
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed: Anselmoo/issue540 #559
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@Anselmoo Anselmoo marked this pull request as ready for review January 23, 2023 21:28
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 23, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 9.43 🙂 9.43 🙂 0.00
Method Length 52.70 ⭐ 52.63 ⭐ -0.07 👍
Working memory 7.40 🙂 7.32 🙂 -0.08 👍
Quality 68.49% 🙂 68.51% 🙂 0.02% 👍
Other metrics Before After Change
Lines 420 418 -2
Changed files Quality Before Quality After Quality Change
spectrafit/report.py 68.49% 🙂 68.51% 🙂 0.02% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/report.py fit_report_as_dict 29 😞 300 ⛔ 14 😞 23.22% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spectrafit/report.py _extracted_gof_from_results 19 😞 213 ⛔ 12 😞 36.66% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added the python Pull requests that update Python code label Jan 23, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #564 (d33abd9) into main (8e9424d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   99.94%   99.94%   -0.00%     
==========================================
  Files          37       37              
  Lines        3178     3175       -3     
==========================================
- Hits         3176     3173       -3     
  Misses          2        2
Impacted Files Coverage Δ
spectrafit/report.py 99.52% <100.00%> (-<0.01%) ⬇️
spectrafit/spectrafit.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anselmoo Anselmoo merged commit 4a588c0 into main Jan 23, 2023
@Anselmoo Anselmoo deleted the fix branch January 23, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Anselmoo