Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feature: 👷 rixs converter #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

feature: 👷 rixs converter #572

merged 1 commit into from
Jan 30, 2023

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jan 26, 2023 •
edited
Loading

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@Anselmoo Anselmoo changed the title ci: 👷 Detail specification of ignore path feature: 👷 rixs converter Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023 •
edited
Loading

Codecov Report

Merging #572 (29b3a6a) into main (d468c1a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 29b3a6a differs from pull request most recent head f1a0a5e. Consider uploading reports for the commit f1a0a5e to get more accurate results

@@             Coverage Diff             @@
##              main     #572      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files           38       40       +2     
  Lines         3269     3521     +252     
===========================================
+ Hits          3269     3520     +251     
- Misses           0        1       +1
Impacted Files Coverage Δ
spectrafit/models.py 100.00% <ø> (ø)
spectrafit/plugins/file_converter.py 100.00% <ø> (ø)
spectrafit/report.py 99.50% <ø> (-0.50%) ⬇️
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/api/file_model.py 100.00% <100.00%> (ø)
spectrafit/api/rixs_model.py 100.00% <100.00%> (ø)
spectrafit/api/test/test_rixs_model.py 100.00% <100.00%> (ø)
spectrafit/plotting.py 100.00% <100.00%> (ø)
spectrafit/plugins/notebook.py 100.00% <100.00%> (ø)
spectrafit/plugins/pkl_converter.py 100.00% <100.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 26, 2023 •
edited
Loading

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.53%.

Quality metrics Before After Change
Complexity 3.09 ⭐ 2.99 ⭐ -0.10 👍
Method Length 67.81 🙂 68.82 🙂 1.01 👎
Working memory 6.66 🙂 6.81 🙂 0.15 👎
Quality 75.34% ⭐ 74.81% 🙂 -0.53% 👎
Other metrics Before After Change
Lines 6858 7186 328
Changed files Quality Before Quality After Quality Change
spectrafit/__init__.py 100.00% ⭐ 100.00% ⭐ 0.00%
spectrafit/models.py 59.31% 🙂 59.31% 🙂 0.00%
spectrafit/plotting.py 62.79% 🙂 62.80% 🙂 0.01% 👍
spectrafit/report.py 68.51% 🙂 68.54% 🙂 0.03% 👍
spectrafit/spectrafit.py 65.94% 🙂 65.67% 🙂 -0.27% 👎
spectrafit/tools.py 78.45% ⭐ 78.45% ⭐ 0.00%
spectrafit/api/file_model.py 87.91% ⭐ 88.90% ⭐ 0.99% 👍
spectrafit/api/rixs_model.py 58.83% 🙂 49.61% 😞 -9.22% 👎
spectrafit/api/test/test_rixs_model.py 82.87% ⭐ 82.87% ⭐ 0.00%
spectrafit/plugins/file_converter.py 79.70% ⭐ 79.70% ⭐ 0.00%
spectrafit/plugins/notebook.py 75.43% ⭐ 75.43% ⭐ 0.00%
spectrafit/plugins/pkl_converter.py 77.91% ⭐ 77.94% ⭐ 0.03% 👍
spectrafit/plugins/pkl_visualizer.py 78.71% ⭐ 78.71% ⭐ 0.00%
spectrafit/plugins/rixs_visualizer.py 63.51% 🙂 65.88% 🙂 2.37% 👍
spectrafit/plugins/test/test_converter.py 83.49% ⭐ 80.13% ⭐ -3.36% 👎
spectrafit/plugins/test/test_notebook.py 85.85% ⭐ 85.85% ⭐ 0.00%
spectrafit/plugins/test/test_rixs_visualizer.py 87.01% ⭐ 86.19% ⭐ -0.82% 👎
spectrafit/test/test_input.py 87.92% ⭐ 85.09% ⭐ -2.83% 👎
spectrafit/test/test_tools.py 86.86% ⭐ 86.84% ⭐ -0.02% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/report.py fit_report_as_dict 29 😞 300 ⛔ 14 😞 23.22% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py calculated_model 20 😞 320 ⛔ 17 ⛔ 24.72% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py SolverModels.solve_global_fitting 15 🙂 314 ⛔ 19 ⛔ 27.10% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py SolverModels.solve_local_fitting 15 🙂 250 ⛔ 18 ⛔ 30.36% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/plugins/notebook.py SpectraFitNotebook.__init__ 3 ⭐ 358 ⛔ 43 ⛔ 32.44% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added github-actions Pull requests that update Github_actions code maintenance Maintenance & Security python Pull requests that update Python code labels Jan 26, 2023
@Anselmoo Anselmoo force-pushed the Anselmoo/issue_540 branch 3 times, most recently from f9f12f5 to 535d4db Compare January 27, 2023 07:24
@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation pre-commit labels Jan 28, 2023
@Anselmoo Anselmoo force-pushed the Anselmoo/issue_540 branch 2 times, most recently from 55f2f15 to 37d584a Compare January 29, 2023 22:00
@Anselmoo Anselmoo added the enhancement New feature or request label Jan 29, 2023
@Anselmoo Anselmoo force-pushed the Anselmoo/issue_540 branch 3 times, most recently from 6c61dbc to 11c4578 Compare January 30, 2023 18:09
@Anselmoo
ci: 👷 Detail specification of ignore path
f1a0a5e 
test: ✅ Update coverage policy

fix: 🐛 Change `utf8` to `utf-8`

fix: 👷 Temporary fix inputs by skipping

test: 💚 Deactivate `verbose` in pytest

fix: 🐛 encoding problem windows

test: ✅ Update coverate policy

fix: ✏️ Bump from `plot` to `plots`

feat: ✨ Introduce `RIXS-Converter`

fix: 🧪 Add missing test for `rixs-coverter`

ci: ⬇️ Bump from `beta` to `v2.15.10`

ci: ⬆️ Update `hooks`

fix: 🚑 Add `command_line_runner` back

test: ✨ Add test for visualizer

fix: 🐛 Correct `script_runner`

fix: 🌱 Imporve `pylint`-score

fix: 🚑 Statement had no side effects

fix: 📝 Reset style

fix: 📝 Crashing docs

fix: 📝 Update jupyter docs

ci: ⚡ Update `pylint` rules

fix: 📝 About docs build
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anselmoo Anselmoo merged commit e175479 into main Jan 30, 2023
@Anselmoo Anselmoo deleted the Anselmoo/issue_540 branch January 30, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request github-actions Pull requests that update Github_actions code maintenance Maintenance & Security pre-commit python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Working with RIXS planes

1 participant

@Anselmoo