Fix ambiguous moves in PGN; Add PGN test case #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add nil check to node parent
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue of ambiguous moves generated in PGNs by updating the move encoding logic to conditionally use the predecessor position for subvariations while preserving legacy behavior for standard moves. It also adds a new test case to capture the ambiguous move scenario reported in #44.
- Fix ambiguous move generation in PGN encoding.
- Update move encoding to use the predecessor position only in subvariation mode.
- Add a test case to verify the correct PGN output for longer games.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| game_test.go | Added a test case ("GameStringWithLongerGame") that verifies PGN output for a longer game sequence. |
| game.go | Modified the writeMoveEncoding function to incorporate a 'subVariation' flag for disambiguation. |
Comments suppressed due to low confidence (2)
game.go:494
- [nitpick] Consider renaming the parameter 'subVariation' to 'isSubVariation' for improved clarity regarding its boolean nature.
func writeMoveEncoding(node *Move, currentMove *Move, subVariation bool, sb *strings.Builder) {
game.go:495
- Add a comment to explain why the parent's position is used when subVariation is true to enhance clarity on the PGN disambiguation logic.
if subVariation && node.Parent() != nil {
Contributor
Author
|
@CorentinGS Could you allow the test workflow to be run? I believe this PR is ready and the new more robust solution fixes the previously failed tests. |
Contributor
Author
|
The error in the latest test run seems to not be related to this PR. It does not happen for me locally and this PR doesn't touch the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ambiguous moves were being generated in game PGNs as per #44. The reason was that the generator was looking at the predecessor position when determining what information was needed for the current move. This PR fixes the issue.
EDIT: The predecessor position was necessary for processing subvariations in the PGN encode. This was brough back in a more robust way, so that ambiguous moves were fixed while keeping the predecessor position for the subvariations. Also added a test case that captures the example from #44