Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix ambiguous moves in PGN; Add PGN test case #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CorentinGS merged 3 commits into from
Jul 7, 2025
Merged

Fix ambiguous moves in PGN; Add PGN test case #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc5a2a9
Fix ambiguous moves in PGN
TheNipanen Jun 22, 2025
7c9f711
Process subvariations more robustly in PGN encode
TheNipanen Jun 28, 2025
8f96f2b
Add test case for ambiguous PGN moves
TheNipanen Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions game.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ func writeMoves(node *Move, moveNum int, isWhite bool, sb *strings.Builder, subV
writeMoveNumber(moveNum, isWhite, subVariation, sb)

// Encode the move using your AlgebraicNotation.
writeMoveEncoding(node, currentMove, sb)
writeMoveEncoding(node, currentMove, subVariation, sb)

// Append a comment if present.
writeComments(currentMove, sb)
Expand Down Expand Up @@ -491,12 +491,12 @@ func writeMoveNumber(moveNum int, isWhite bool, subVariation bool, sb *strings.B
}
}

func writeMoveEncoding(node *Move, currentMove *Move, sb *strings.Builder) {
if node.Parent() == nil {
sb.WriteString(AlgebraicNotation{}.Encode(node.Position(), currentMove))
} else {
func writeMoveEncoding(node *Move, currentMove *Move, subVariation bool, sb *strings.Builder) {
if subVariation && node.Parent() != nil {
moveStr := AlgebraicNotation{}.Encode(node.Parent().Position(), currentMove)
sb.WriteString(moveStr)
} else {
sb.WriteString(AlgebraicNotation{}.Encode(node.Position(), currentMove))
}
}

Expand Down
17 changes: 17 additions & 0 deletions game_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,6 +1045,23 @@ func TestGameString(t *testing.T) {
},
expected: "1. e4 e5 2. Nf3 *",
},
{
name: "GameStringWithLongerGame",
setup: func() *Game {
g := NewGame()
_ = g.PushMove("Nf3", nil)
_ = g.PushMove("Nc6", nil)
_ = g.PushMove("Nc3", nil)
_ = g.PushMove("e6", nil)
_ = g.PushMove("e4", nil)
_ = g.PushMove("a6", nil)
_ = g.PushMove("Ne2", nil)
_ = g.PushMove("Nf6", nil)
_ = g.PushMove("Ned4", nil)
return g
},
expected: "1. Nf3 Nc6 2. Nc3 e6 3. e4 a6 4. Ne2 Nf6 5. Ned4 *",
},
{
name: "GameStringWithComments",
setup: func() *Game {
Expand Down
Loading