Make injectOn use the definition cache
#709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jdreesen
reviewed
Mar 20, 2020
Before this change `injectOn` was not using the Container internal definition cache and insetad solely built on the optional SourceCache mechanism. This is costly for setups with a long-running processes with APCu as every `injectOn` call will lead to a full annotation and autowiring run. This change makes `injectOn` use the definition cache for all objects of non-anonymous classes. Anonymmous objects are ignored to make sure the cache does not get overloaded with many unusable definitions. It also includes a basic test which tests for minimum compatibility of `injectOn` with anonymous classes.
55d6f1c to
90988ca
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
injectOnwas not using the Container internal definition cache and insetad solely built on the optional SourceCache mechanism. This is costly for setups with a long-running processes with APCu as everyinjectOncall will lead to a full annotation and autowiring run.This change makes
injectOnuse the definition cache for all objects of non-anonymous classes. Anonymmous objects are ignored to make sure the cache does not get overloaded with many unusable definitions. It also includes a basic test which tests for minimum compatibility ofinjectOnwith anonymous classes.
This PR is a simpler alternative to #647.