Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make injectOn use the definition cache #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Make injectOn use the definition cache #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,14 @@ public function injectOn($instance)
return $instance;
}

$objectDefinition = $this->definitionSource->getDefinition(get_class($instance));
$className = get_class($instance);

// If the class is anonymous don't cache its definition
// Checking for anonymous classes is cleaner via Reflection but also less slower
$objectDefinition = false !== strpos($className, '@anonymous')
? $this->definitionSource->getDefinition($className)
: $this->getDefinition($className);

if (! $objectDefinition instanceof ObjectDefinition) {
return $instance;
}
Expand Down
31 changes: 31 additions & 0 deletions tests/IntegrationTest/ContainerInjectOnTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,35 @@ public function test_inject_on_object_using_config(ContainerBuilder $builder)
$proxy = $obj->method4Param1;
self::assertFalse($proxy->isProxyInitialized());
}

/**
* @dataProvider provideContainer
*/
public function testInjectOnAnonClass(ContainerBuilder $builder)
{
$obj = new class {
/**
* @Inject
* @var Class2
*/
public $property;

public $methodParam;

/**
* @Inject
*/
public function setParam(Class2 $param)
{
$this->methodParam = $param;
}
};

$builder->useAnnotations(true);
$container = $builder->build();
$container->injectOn($obj);

$this->assertInstanceOf(Class2::class, $obj->property);
$this->assertInstanceOf(Class2::class, $obj->methodParam);
}
}