Add nightly docker tag and pull instructions #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodden
suggested changes
Jul 8, 2025
README.md
Outdated
| Nightly docker images are kept in the Github Container Registry | ||
|
|
||
| ``` | ||
| echo <Github PAT> | docker login ghcr.io -u <username> --password-stdin |
Contributor
There was a problem hiding this comment.
Instead of PAT, lets use a more self-descriptive term here
Suggested change
| echo <Github PAT> | docker login ghcr.io -u <username> --password-stdin | |
| echo <YOUR_GITHUB_ACCESS_TOKEN> | docker login ghcr.io -u <username> --password-stdin |
|
|
||
| Pull access to the Github CR is done by a personal access token (classic) with the `read:packages` permission. To create one, click your profile picture in the top-right of Github, select Settings > Developer settings > Personal access tokens > Tokens (classic) and then select the option to generate a new token. Make sure you select the classic token option and git it the `read:packages` permission. | ||
|
|
||
| Once your token has been created, go back to the Tokens (classic) page and set your token's SSO settings to allow access to the ROCm Github organization. |
README.md
Outdated
| Once your token has been set up to use SSO, you can log in with the `docker` command line by running, | ||
|
|
||
| ``` | ||
| echo <Github PAT> | docker login ghcr.io -u <username> --password-stdin |
Contributor
There was a problem hiding this comment.
Suggested change
| echo <Github PAT> | docker login ghcr.io -u <username> --password-stdin | |
| echo <GITHUB_ACCESS_TOKEN> | docker login ghcr.io -u <username> --password-stdin |
5501d52 to
7a6b1fa
Compare
7a6b1fa to
530889e
Compare
gulsumgudukbay
approved these changes
Jul 9, 2025
Contributor
gulsumgudukbay
left a comment
There was a problem hiding this comment.
LGTM and instructions are clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been building nightly wheels and docker images for a while. This adds a
nightlytag to the built docker images and instructions to the README that explains how to get the nightly images and wheels.