Audio support - Replace Audio QA samples#616
Merged
rrawther merged 27 commits intoROCm:developfrom Oct 29, 2025
Merged
Conversation
Audio QA with New Audio Input Samples
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the audio test suite to support new MIVisionX-data samples by replacing input audio samples and regenerating golden outputs for RPP audio functionality. The changes include updating input parameters to match new audio sample dimensions and standardizing buffer calculations.
- Replace hardcoded buffer sizes with defined constants for better maintainability
- Update golden output values for Non Silent Region Detection to match new audio samples
- Modify input parameters (dimensions, sample rates) to align with new test dataset
- Standardize error return codes across HOST and HIP implementations
Reviewed Changes
Copilot reviewed 3 out of 17 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| utilities/test_suite/rpp_test_suite_audio.h | Defines new constants and updates golden output values for new audio samples |
| utilities/test_suite/HOST/Tensor_audio_host.cpp | Updates buffer calculations, sample rates, and tensor dimensions for new dataset |
| utilities/test_suite/HIP/Tensor_audio_hip.cpp | Applies similar updates to HIP implementation with consistent changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #616 +/- ##
===========================================
- Coverage 88.23% 88.23% -0.01%
===========================================
Files 195 195
Lines 82768 82768
===========================================
- Hits 73029 73023 -6
- Misses 9739 9745 +6 🚀 New features to boost your workflow:
|
rrawther
reviewed
Sep 23, 2025
rrawther
reviewed
Sep 23, 2025
rrawther
reviewed
Sep 23, 2025
| descriptorPtr3D->dataType = RpptDataType::F32; | ||
| descriptorPtr3D->dims[0] = batchSize; | ||
| descriptorPtr3D->dims[1] = maxSrcWidth; | ||
| descriptorPtr3D->dims[1] = (maxSrcWidth / 8) * 8 + 8; // Ensure a consistent dimension order between generic and typed descriptors to prevent errors. |
Contributor
There was a problem hiding this comment.
Not sure why this is needed?
Member
Author
There was a problem hiding this comment.
this was to ensure descriptor dims[1] is maxSrcWidth or higher, but a multiple of 8 for vectorized versions
Contributor
There was a problem hiding this comment.
then (maxSrcWidth + 8) & ^7 would be better and more efficient
Contributor
There was a problem hiding this comment.
I am not seeing it reflected in the code
rrawther
requested changes
Sep 23, 2025
Contributor
rrawther
left a comment
There was a problem hiding this comment.
Please address review comments
…access QA golden output from bin files
AUDIO Support - Fix Copilot comments
rrawther
reviewed
Oct 3, 2025
rrawther
requested changes
Oct 3, 2025
Contributor
rrawther
left a comment
There was a problem hiding this comment.
added few more comments
Audio QA support - review comments resolved
Audio QA PR: Review comments resolution
rrawther
approved these changes
Oct 29, 2025
ManasaDattaT
pushed a commit
to RooseweltMcW/rpp
that referenced
this pull request
Dec 19, 2025
* Modified single, multi channel audio and generated QA * Added QA support for other kernels * Updated bin files for QA * Updated and modified slice bin file for QA * Resolved review comments and made modifications to the parameters * Modified parameters, updated the names and output docs image * Resolved review comments and modified non silent region detection to access QA golden output from bin files * Modified and used oBufferSize as base directly to the resampleBuffer size calculation * Updated compare function for non silent region * Resolved review comments * Updated comments for mel filter bank * Updated comments for resample --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Lakshmi Kumar <[email protected]>
HazarathKumarM
added a commit
to HazarathKumarM/rpp
that referenced
this pull request
Jan 6, 2026
* Modified single, multi channel audio and generated QA * Added QA support for other kernels * Updated bin files for QA * Updated and modified slice bin file for QA * Resolved review comments and made modifications to the parameters * Modified parameters, updated the names and output docs image * Resolved review comments and modified non silent region detection to access QA golden output from bin files * Modified and used oBufferSize as base directly to the resampleBuffer size calculation * Updated compare function for non silent region * Resolved review comments * Updated comments for mel filter bank * Updated comments for resample --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Lakshmi Kumar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a audio test suite QA PR to: