#9862 Number of items in order summary page #9898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Nov 6, 2018
Contributor
lchrusciel
left a comment
There was a problem hiding this comment.
Thanks a lot for contribution Laurent!
Will you give a try to add a behat scenario for this as well?
Contributor
Author
|
@lchrusciel Sure I will give it a try |
pamil
approved these changes
Nov 7, 2018
src/Sylius/Bundle/ShopBundle/Resources/views/Order/_summary.html.twig
Outdated
Show resolved
Hide resolved
923412d to
c6b96a0
Compare
Zales0123
reviewed
Nov 8, 2018
...kout/paying_for_order/changing_payment_method_after_order_confirmation_item_quantity.feature
Outdated
Show resolved
Hide resolved
...kout/paying_for_order/changing_payment_method_after_order_confirmation_item_quantity.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutOrderDetailsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutOrderDetailsContext.php
Outdated
Show resolved
Hide resolved
| </div> | ||
| <div class="item"> | ||
| {{ order.items|length }} {{ 'sylius.ui.items'|trans|lower }} | ||
| {{ order.totalQuantity }} {{ 'sylius.ui.items'|trans|lower }} |
Contributor
There was a problem hiding this comment.
I'm wondering, maybe we should change the 'sylius.ui.items' translation as well? I agree that there we should have a total quantity of the order, but then it should be something like 4 units or 4 products or whatever, instead of 4 items as order item can be indeed 1 :)
Contributor
Author
There was a problem hiding this comment.
I think items is the good word here.
It is the same word used in Amazon cart page even if you order several time the same product.
@Zales0123 let me know if it is ok for you
758c1df to
043819c
Compare
Contributor
|
Thanks, Laurent! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing number of items displayed in order summary page