Thanks to visit codestin.com
Credit goes to github.com

Skip to content

#9862 Number of items in order summary page #9898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zales0123 merged 2 commits into from
Nov 12, 2018
Merged

#9862 Number of items in order summary page #9898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6b96a0
#9862 Number of items in order summary page
laurent35240 Nov 5, 2018
043819c
#9862 BDD test for item quantity on changing payment method page
laurent35240 Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...t/paying_for_order/changing_payment_method_after_order_confirmation_item_quantity.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
@paying_for_order
Feature: Having good number of items in changing payment method page
In order to verify that I am changing the payment method of correct order
As a Customer
I want to see correct details about my order on changing the payment method page

Background:
Given the store operates on a single channel in "United States"
And there is a user "[email protected]" identified by "password123"
And the store allows paying "Offline"
And the store allows paying "Cash on delivery"
And the store has a product "PHP T-Shirt" priced at "$19.99"
And the store ships everywhere for free
And I am logged in as "[email protected]"

@ui
Scenario: Seeing correct quantity on payment retry page
Given I have added 2 products "PHP T-Shirt" to the cart
And I have proceeded selecting "Cash on delivery" payment method
And I have confirmed order
When I go to order details
Then I should see 2 as number of items
8 changes: 8 additions & 0 deletions src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutOrderDetailsContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,12 @@ public function iShouldNotBeAbleToPay()
{
Assert::false($this->orderDetails->hasPayAction());
}

/**
* @Then I should see :quantity as number of items
*/
public function iShouldSeeAsNumberOfItems(int $quantity): void
{
Assert::same($this->orderDetails->getNumberOfItems(), $quantity);
}
}
12 changes: 12 additions & 0 deletions src/Sylius/Behat/Page/Shop/Order/ShowPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,25 @@ public function getRouteName()
return 'sylius_shop_order_show';
}

/**
* @inheritdoc
*/
public function getNumberOfItems(): int
{
$itemsText = trim($this->getElement('items_text')->getText());
$itemsTextWords = explode(' ', $itemsText);

return (int) $itemsTextWords[0];
}

/**
* {@inheritdoc}
*/
protected function getDefinedElements()
{
return array_merge(parent::getDefinedElements(), [
'instructions' => '#sylius-payment-method-instructions',
'items_text' => 'div.sub.header div.item:nth-child(3)',
'pay_link' => '#sylius-pay-link',
'payment_method' => '.item:contains("%name%") input',
'thank_you' => '#sylius-thank-you',
Expand Down
2 changes: 2 additions & 0 deletions src/Sylius/Behat/Page/Shop/Order/ShowPageInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,6 @@ public function choosePaymentMethod($paymentMethodName);
* @return string[]
*/
public function getNotifications();

public function getNumberOfItems(): int;
}
2 changes: 1 addition & 1 deletion src/Sylius/Bundle/ShopBundle/Resources/views/Order/_summary.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
{{ money.convertAndFormat(order.total) }}
</div>
<div class="item">
{{ order.items|length }} {{ 'sylius.ui.items'|trans|lower }}
{{ order.totalQuantity }} {{ 'sylius.ui.items'|trans|lower }}
Copy link
Contributor

@Zales0123 Zales0123 Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering, maybe we should change the 'sylius.ui.items' translation as well? I agree that there we should have a total quantity of the order, but then it should be something like 4 units or 4 products or whatever, instead of 4 items as order item can be indeed 1 :)

Copy link
Contributor Author

@laurent35240 laurent35240 Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think items is the good word here.
It is the same word used in Amazon cart page even if you order several time the same product.
amazon com shopping cart

@Zales0123 let me know if it is ok for you

Copy link
Contributor

@Zales0123 Zales0123 Nov 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

</div>
</div>
</div>
Expand Down