Create a d3aa firmware variant with jumpstart, and fix a bug where channel mode config could be accessed from off if globals config was not enabled #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ea9bd8 to
fbbd8f0
Compare
Contributor
|
What about other modes like lockout? Handling 9H in a global "super" state might be too much if we want it only in "on". I'd even say it should be available only in the ramping state, because it doesn't make much sense in e.g. battery check or a strobe mode. |
Contributor
Agreed. And so far, I have only ever seen references to 9H from On for channel mode config. I am not sure that it is widely known at all that 9H for channel mode config is presently also accessible from Lockout (and from Off, if there is no misc/globals config). |
Contributor
Author
|
Yeah, good catch, probably better to just use a check for if state == steady_state on the event. Edit: Done. |
0c37b74 to
ffcfcdb
Compare
…annel mode config could be accessed from off if globals config was not enabled
ffcfcdb to
23dfcb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99