-
Notifications
You must be signed in to change notification settings - Fork 23
update to main #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
update to main #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excel conditional formatting update
handle empty column type for joining data format
Manual additional of additional alias between ATTAINS ParameterName and WQP CharacteristicName
Changed to "Not Applicable for Analysis" as the drop down value for TADA_CreateParamRef
Some code styling changes and arranged drop down by ascending. Do we want the "Not applicable for Analysis" option to show up in the top or bottom in Excel? We mentioned top but it seems like clicking on the drop down will show bottom entries first
Changed offset to 100 for ATTAINS geospatial webservices
Renamed to consistent column names between helper function and spatial crosswalk with AU spatial summary.
Added Char, spec, frac to CriteriaMethods. Reformat excel file
Changed column name to ATTAINS.WaterType throughout crosswalk tables. Edited format of excel spreadsheet outputs.
Edit to required columns. DepthProfile fix incorporated
…f workflow Reordered workflow of functions and changed function name New order: TADA_CreateWaterUseRef -> TADA_CreateUseAURef Users should run these functions as part of Module 2 now. These functions aim to help with assigning Uses to AU once sites have been joined to AUs.
This PR focuses on assigning ATTAINS Use Name to each AU. There are two functions in this PR: TADA_CreateUseAURef and TADA_CreateWaterUseRef TADA_CreateWaterUseRef is a helper function to help assign ATTAINS Use to new/updated AUs. This function excludes other Mod 3 functions for the time being.
Used a sample data input for testinf and forgot to change back to sitesAURef
Added global variables to utilities Fixed Function documentation in CreateWaterUseRef Ran styler and word list maintainence
handle NULL dfs
TADA_CreateAUMLCrosswalk, TADA_IDCensoredData, Mod 2 vignette
ATTAINS.WaterType was missing in the example. Updated some text.
set eval - TRUE
…to combined-review
…to combined-review
…to combined-review
update branch ref for knitting vignette
don't run multi org dups
Combined PR review
updating this in a separate PR
4b43e11
into
632-leverage-coverage-in-pr-review
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main is passing now