Thanks to visit codestin.com
Credit goes to github.com

Skip to content

632 leverage coverage in pr review #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristinamullin merged 10 commits into from
Sep 25, 2025
Merged

632 leverage coverage in pr review #656

cristinamullin merged 10 commits into from
Sep 25, 2025

Conversation

@jbousquin
Copy link
Collaborator

@jbousquin jbousquin commented Sep 25, 2025

Ready for review. Bot should add coverage report as comment on new PRs to develop.

jbousquin and others added 10 commits August 15, 2025 12:32
@jbousquin
Update test-coverage.yaml
ca9d68e 
Update coverage action to use different covr function. Not sure this requires GITHUB_PAT anymore. If uploading to codecov use codecov/codecov-action@v5 and toekn (i.e., secrets.CODECOV_TOKEN)
@jbousquin
Update test-coverage.yaml
19fb73b 
Clean up to make sure these unknowns weren't causing failure.
@jbousquin
Update test-coverage.yaml
8485aca 
Unintentionally deleted an important line.
@jbousquin
Update test-coverage.yaml
35326b8 
Temp run on branch
@jbousquin
Update test-coverage.yaml
b0e440e 
Attempt to upload report as artifact
@jbousquin
Merge pull request #650 from USEPA/develop
4b43e11 
update to main
@jbousquin
Update test-coverage.yaml
7f0319b 
Update where coverage report is expected to have been written (upload to artifact and use in comment action)
@jbousquin
Merge remote-tracking branch 'origin/develop' into 632-leverage-cover…
52316ec 
…age-in-pr-review

Update to main (develop)
@cristinamullin
update WQX refs
f273029
@jbousquin
Update test-coverage.yaml
705e47b 
Prep for PR
@jbousquin jbousquin linked an issue Sep 25, 2025 that may be closed by this pull request
Leverage coverage in PR review #632
Closed
8 tasks
jbousquin
jbousquin commented Sep 25, 2025
View reviewed changes
.github/workflows/test-coverage.yaml

- name: Comment coverage
uses: 5monkeys/cobertura-action@master
with:
Copy link
Collaborator Author

@jbousquin jbousquin Sep 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add/update with inputs to this part of workflow if you want to change what is included in coverage comment (e.g., only_changed_files if you only want coverage for files changed by the PR)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

coverage-report

File Coverage Missing
All files 32% ✅
R/ATTAINSCrosswalks.R 0% ❌ 60-2663
R/ATTAINSRefTables.R 0% ❌ 17-225
R/autoClean.R 77% ✅ 139-140 168 176 183 190 197 204 211 218 225 236-242 373-374 384-388
R/autoFilter.R 0% ❌ 27-430
R/CensoredDataSuite.R 88% ✅ 48-49 146 176-177 219-221 307-308 406-407 420 423 431 459-463 466-467 473-475 492-494
R/ContinuousDataFunctions.R 53% ✅ 151-152 184 189-259 266-267 290-328 345-349 352 392-393 483-547 552-596 603-610 615-616 655 666 672 677-684 709
R/CriteriaComparison.R 89% ✅ 159-161 166 176 223-241
R/CriteriaRefTables.R 0% ❌ 26-83
R/DataDiscoveryRetrieval.R 34% ✅ 197 206-211 225-230 240-245 251 255 270-676 690 698 700 704-707 710 716 718 722 724 730 734 736 746 748 752 758 760 764 766 771 773 777 783-786 789 801-809 822-828 857-865 879-887 907 1001-1033 1120-1127 1211-1214 1216 1222 1245-1281 1366-1369 1421-1580
R/DepthProfile.R 0% ❌ 96-1472
R/Figures.R 0% ❌ 64-1555
R/GeospatialFunctions.R 19% ✅ 71 164-166 177-181 185 240 278 322-549 690-691 697-700 709-923 928-1112 1291-1302 1319-1321 1323 1390 1396-1440 1531-1536 1542-1627 1637-2079 2150-3594
R/RequiredCols.R 16% ✅ 359-581
R/ResultFlagsDependent.R 63% ✅ 59-60 65 95-99 119-123 221 247-249 266-268 275 291-302 397 404 411 420 477 483 499-508 576 588-595 617 628-632 700-790 888 937-945 966 970 976-980
R/ResultFlagsIndependent.R 48% ✅ 71 77 110-136 242 250 257 264 269 280 352-353 370-407 496 501 508 579-588 599-614 704 709 715 792-796 807-963 1013 1043-1064 1168 1172 1215-1226 1231 1235-1238 1304-1542
R/Tables.R 77% ✅ 19-30 86
R/TADAGeospatialRefLayers.R 0% ❌ 8-13
R/TADARefTables.R 84% ✅ 75 85-89
R/Transformations.R 95% ✅ 71-72 100 190-196 331-332 398-399 483-484 560-561
R/UnitConversions.R 81% ✅ 128 233-236 344 351 358 365 372 379 386 393-394 521-585 609-646 669 709 723-732 913-915 1005 1062-1065 1095
R/Utilities.R 49% ✅ 38-42 186 202-203 304-305 309 314 387 489-497 559-560 569 626-627 665-669 752 846-847 859-860 865 880-883 886-895 899 935-1228 1254-1255 1266-1267 1327-1628
R/WQPWQXRefTables.R 63% ✅ 21-78 102 112 118-120 132 154 164 170-172 247 269 279 285-287 371 392 402 408-412 556 578 588 594-596 613 637 647 653-655 760-963

Minimum allowed coverage is 10%

Generated by 🐒 cobertura-action against 705e47b

@cristinamullin cristinamullin merged commit f15844c into develop Sep 25, 2025
8 checks passed
@cristinamullin cristinamullin deleted the 632-leverage-coverage-in-pr-review branch September 25, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristinamullin cristinamullin cristinamullin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Leverage coverage in PR review

3 participants

@jbousquin @cristinamullin