Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Maintenance branch #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristinamullin merged 5 commits into from
Oct 16, 2025
Merged

Maintenance branch #683

cristinamullin merged 5 commits into from
Oct 16, 2025

Conversation

@jbousquin
Copy link
Collaborator

@jbousquin jbousquin commented Oct 16, 2025

Periodic updates.
Note: I was looking at some at some of the files updated and it looked like some of the changes might just be changed order - how much are these results sorted before saving?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025 •
edited
Loading

coverage-report

File Coverage Missing
All files 33% ✅
R/ATTAINSCrosswalks.R 22% ✅ 64-742 931-941 945-949 954-957 962 970-973 980-983 988-1009 1017-1027 1052-1055 1179-1254 1266 1273-1451 1621-1633 1637-1640 1645-1647 1675-1678 1689-1692 1700-1704 1716-1720 1732-1738 1743-1754 1760 1768-1771 1861-1867 1872-1874 1979 1986-2157 2338-2724 2850-2853 2868 2876-2879 2886-2904 2912-2916 2927-2931 2947-3009 3056-3146 3151-3154 3159-3253
R/ATTAINSRefTables.R 0% ❌ 17-226
R/autoClean.R 85% ✅ 138-139 235-241 369-370 380-384
R/autoFilter.R 0% ❌ 27-430
R/CensoredDataSuite.R 88% ✅ 48-49 146 176-177 219-221 307-308 406-407 420 423 431 459-463 466-467 473-475 492-494
R/ContinuousDataFunctions.R 53% ✅ 151-152 184 189-259 266-267 290-328 345-349 352 392-393 483-547 552-596 603-610 615-616 655 666 672 677-684 709
R/CriteriaComparison.R 89% ✅ 159-161 166 176 223-241
R/CriteriaMethods.R 23% ✅ 155 175 185 191-250 404-406 422-424 529-669 675-711 733-984 1005-1173
R/CriteriaRefTables.R 0% ❌ 26-83
R/DataDiscoveryRetrieval.R 33% ✅ 197 206-211 225-230 240-245 251 255 270-676 690 698 700 704-707 710 716 718 722 724 730 734 736 746 748 752 758 760 764 766 771 773 777 783-786 789 801-809 822-828 857-865 879-887 907 1001-1033 1138-1145 1236-1272 1360-1363 1415-1574
R/DepthProfile.R 0% ❌ 96-1472
R/Figures.R 0% ❌ 64-1555
R/GeospatialFunctions.R 18% ✅ 70 163-165 176-180 184 239 277 321-548 689-690 696-699 708-922 927-1111 1279-1290 1307-1309 1311 1339 1345-1389 1416-1418 1496-1579 1589-2123 2204 2247 2268-3743
R/MaintenanceScheduled.R 0% ❌ 42-349
R/RequiredCols.R 16% ✅ 359-581
R/ResultFlagsDependent.R 63% ✅ 59 64 94-98 118-122 220 246-248 265-267 274 290-301 396 403 410 419 464 476 482 488 498-507 575 587-594 616 627-631 699-787 885 934-942 963 967 973-977
R/ResultFlagsIndependent.R 48% ✅ 71 77 111-112 128-136 242 250 257 264 269 280 352-353 370-407 496 501 508 579-588 599-614 704 709 715 792-972 1022 1040-1059 1070-1073 1177 1181 1224-1235 1240 1244-1247 1313-1551
R/Tables.R 77% ✅ 19-30 86
R/TADAGeospatialRefLayers.R 0% ❌ 8-13
R/TADARefTables.R 84% ✅ 75 85-89
R/Transformations.R 92% ✅ 71-72 100 190-196 329-330 396-397 481-482 557-558 726-739
R/UnitConversions.R 81% ✅ 128 344 351 358 365 372 379 386 393-394 521-585 609-646 669 709 723-732 913-915 1005 1062-1065 1095
R/Utilities.R 51% ✅ 28-32 183 199-200 301-302 306 311 384 486-494 556-557 566 623-624 662-666 764-765 774-778 783-784 859-860 872-873 878 893-896 899-908 912 948-1241 1267-1268 1279-1280 1340-1689 1781-1813
R/WQPWQXRefTables.R 63% ✅ 21-78 102 112 118-120 132 154 164 170-172 247 269 279 285-287 371 392 402 408-412 556 578 588 594-596 613 637 647 653-655 760-963

Minimum allowed coverage is 10%

Generated by 🐒 cobertura-action against 371e274

@cristinamullin
Copy link
Collaborator

cristinamullin commented Oct 16, 2025

Periodic updates. Note: I was looking at some at some of the files updated and it looked like some of the changes might just be changed order - how much are these results sorted before saving?

We order the columns - this runs within most functions: TADA_OrderCols()

So that ordering would happen for the example data produced. I don't think we order the rows, though they could potentially be ordered by result ID if you think that would be helpful?

For the reference files, I don't believe we do any ordering.

@jbousquin
Copy link
Collaborator Author

jbousquin commented Oct 16, 2025 •
edited
Loading

I'd trust the reference data coming in (response from the service) to have more consistent column than row order. The data will be the same, just hopefully fewer updates that aren't real changes. More specifically - seeing this in the csv files. Will generate issue for it.

Update: #684

@cristinamullin cristinamullin merged commit f4343e6 into develop Oct 16, 2025
8 checks passed
@cristinamullin cristinamullin deleted the maintenance-branch branch October 16, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristinamullin cristinamullin cristinamullin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbousquin @cristinamullin