-
Notifications
You must be signed in to change notification settings - Fork 9
69 change api host from cloudgov to new local host throughout ctxr #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
69 change api host from cloudgov to new local host throughout ctxr #72
Conversation
|
@carolinering and I are both having issues with the following functions: bpa_info <- get_chem_info(DTXSID = 'DTXSID7020182')
biosolids_info <- get_chem_info_batch(DTXSID = biosolids2021$dtxsid)
bpa_hazard <- get_hazard_by_dtxsid(DTXSID = 'DTXSID7020182')
bpa_hhazard <- get_human_hazard_by_dtxsid(DTXSID = 'DTXSID7020182')
|
|
Possible reason for the failure of
We will have to write new functions for each of these, and rewrite (I suggest that the new functions be called something like |
|
The failure of |
|
These functions indeed have been affected by changes in the schema. We could deprecate the current affected functions and write functions for the new endpoints, with more descriptive names. |
…patibility due to changes in API endpoints.
|
I have updated the chemical endpoint functions ( |
Getting an error that the props functions do not exist for some reason: |
|
Added function documentation, including export calls, so those new functions should now work as expected when called. |
madison-feshuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! All tested functions now work on the new server! New chem prop functions work as well.
This closes #69 for Chemical, Bioactivity, and Hazard endpoints. PR 49 closes #69 for Exposure endpoints.