-
Notifications
You must be signed in to change notification settings - Fork 100
Further Map Compatibility additions. #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I can't help but be curious if these may have been intentional. Especially with many of them only affecting easy skill levels, it makes me wonder if they purposely made 100% impossible on easy skill levels (which doesn't seem too crazy of an idea to me?). If it was purposely made that way, I'm not sure it's on us to "fix" it, so it may be a good idea to get verification that it is unintentional. |
|
I can't see any logical reason why that would be something that would be done. Especially considering I've seen a few map fixes that actually do allow monsters to teleport on all difficulties instead of just the harder ones. |
|
Deliberate aesthetic choice to make something look janky and incomplete for diegetic reasons I can get. Deliberate gameplay choice to frustrate players for playing on easy, frankly the kind of person who intends that kind of thing's artistic vision is probably best summarily disregarded. But also overwhelmingly unlikely compared to someone just never testing on easy and accidentally leaving something (un)flagged in an actor - a mistake I've seen and done not at all infrequently. |
|
Nice work :) Can you make sure you rebase instead of merging when you pull in updates to this branch? |
Yeah sure thing, how do I do that? Not too familar with it. |
To make it so easy skills are more limited, not unlike games that give different endings based on the skill level you play at. Maybe it's not too likely, but it doesn't seem that far fetched that the thought came to me, is all. |
It depends on how you are interfacing with git. I do: If you use github desktop, this looks like the instructions for it https://docs.github.com/en/desktop/working-with-your-remote-repository-on-github-or-github-enterprise/syncing-your-branch-in-github-desktop#rebasing-your-project-branch-onto-another-branch Alternatively: When this pr is ready, I can fix the merge commits for you |
|
Kama Sutra MAP15, if you're going to the secret map, 100% kills becomes impossible, and because of the nature of the mod, not sure if it's deliberate or not, worth having the monsters in the shootout area not count towards kills? |
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for opening this PR! We'll review it soon.I'm a bot that checks for some common problems. I'll update this comment with anything I find. Looks like it's your first time contributing!
Nothing to report. Nice :) |
|
@the-phinet Got a batch of map fixes all ready for merging. Will do another batch some other time. :) |
|
Nice! Can you add your signature to the bottom of the CONTRIBUTORS file? |
All done. :) |
|
I see that there are many different commits with the same message. Besides fixes for the same wad used to be close to each other. |
Uh oh!
There was an error while loading. Please reload this page.