Harden JIT job control against cctors deadlocking. (#7423) #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [mini] Don't wait for other threads to finish JITing if the current thread is running a cctor. This eliminates a possible source of deadlocks found during AOT runs of Roslyn. * [mini] Introduce a 1s timeout to JIT job control to ensure we don't simply deadlock in case of execution dependency bugs. * [mini] fix spelling5DD
Collaborator
|
|
joncham
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates a possible source of deadlocks found during AOT runs of Roslyn.
[mini] Introduce a 1s timeout to JIT job control to ensure we don't simply deadlock in case of execution dependency bugs.
[mini] fix spelling5DD
Heard from customer that the fix from upstream has eliminated the hang that they were experiencing.
Reviewers: please consider these questions as well! ❤️
Release notes
Fixed case 1341730 @UnityAlex :
Mono: Fixed rare hang that would occur when opening the editor during asset import.
Backports
2019.4