Harden JIT job control against cctors deadlocking. #7423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hread is running a cctor. This eliminates a possible source of deadlocks found during AOT runs of Roslyn.
…imply deadlock in case of execution dependency bugs.
luhenry
reviewed
Mar 5, 2018
mono/mini/mini-runtime.c
Outdated
| //Dependency management is too compilated and we want to get rid of this anyways. | ||
|
|
||
| //We can't suspend the current thread if it's running a protected block (such as a cctor) | ||
| //We can't relie only on JIT nesting as cctor's can be run from outside the JIT. |
jaykrell
reviewed
Mar 5, 2018
mono/mini/mini-runtime.c
Outdated
| //We can't suspend the current thread if it's running a protected block (such as a cctor) | ||
| //We can't relie only on JIT nesting as cctor's can be run from outside the JIT. | ||
|
|
||
| //Finally, he hit a timeout or spurious wakeup. We're better of just giving up and keep recompiling |
luhenry
approved these changes
Mar 6, 2018
Contributor
Author
|
Fixed spelling. |
vargaz
reviewed
Mar 6, 2018
| g_assert (entry->has_cond); | ||
| mono_coop_cond_wait (&entry->cond, &compilation_data.lock); | ||
| mono_coop_cond_timedwait (&entry->cond, &compilation_data.lock, MAX_JIT_TIMEOUT_MS); | ||
| --entry->threads_waiting; |
Contributor
There was a problem hiding this comment.
Doesn't this going to mask bugs ?
Contributor
Author
There was a problem hiding this comment.
Yes, it will.
OTH, it ensures progress can be made even if slow enough. Do you think it's not worth it?
Contributor
|
@monojenkins build Windows x64 |
Contributor
|
@monojenkins build Windows i386 |
Contributor
|
@monojenkins build OS X x64 |
Contributor
|
@monojenkins build Linux x64 Acceptance Tests |
Contributor
|
@monojenkins build Linux AArch64 |
Contributor
|
@marek-safar I am not sure we wanted to merge it 😉 @kumpera can you confirm if we should revert or keep it? |
Contributor
Author
|
I think me and Zoltan were undecided on whether use a timeout and ensure progress or keep it invite and make bugs evident. Merging this is fine. In case we decide of the later, I'll do a followup PR. |
Contributor
Author
|
@vargaz what do you think? |
Contributor
|
I didn't like the timeout, but its fine. |
Contributor
|
@monojenkins backport 2018-02 |
UnityAlex
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Oct 12, 2021
* [mini] Don't wait for other threads to finish JITing if the current thread is running a cctor. This eliminates a possible source of deadlocks found during AOT runs of Roslyn. * [mini] Introduce a 1s timeout to JIT job control to ensure we don't simply deadlock in case of execution dependency bugs. * [mini] fix spelling5DD
UnityAlex
added a commit
to Unity-Technologies/mono
that referenced
this pull request
Oct 26, 2021
…1730-blindfix Harden JIT job control against cctors deadlocking. (mono#7423)
dtomar-rythmos
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Dec 23, 2021
* [mini] Don't wait for other threads to finish JITing if the current thread is running a cctor. This eliminates a possible source of deadlocks found during AOT runs of Roslyn. * [mini] Introduce a 1s timeout to JIT job control to ensure we don't simply deadlock in case of execution dependency bugs. * [mini] fix spelling5DD
dtomar-rythmos
added a commit
to Unity-Technologies/mono
that referenced
this pull request
Jan 5, 2022
…1730-blindfix Harden JIT job control against cctors deadlocking. (mono#7423)
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* [mini] Don't wait for other threads to finish JITing if the current thread is running a cctor. This eliminates a possible source of deadlocks found during AOT runs of Roslyn. * [mini] Introduce a 1s timeout to JIT job control to ensure we don't simply deadlock in case of execution dependency bugs. * [mini] fix spelling5DD Commit migrated from mono/mono@74daf13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.